Page MenuHomePhabricator
Create Task
Maniphest T72074

VisualEditor: .topicon icons are taking editors to linked pages, rather than letting them edit the template, in MonoBook on English Wikipedia
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Open page containing the {{good article}} (or similar) template in VisualEditor, such as https://en.wikipedia.org/w/index.php?oldid=622810787 (which contains only that template)
  1. Click the good article icon/template
  1. VisualEditor exits, and you are reading the Wikipedia:Good article page (the same one that you would be reading if you clicked that icon in 'read' mode).

Expected behavior:

  1. Open page containing {{good article}} in VisualEditor
  1. Click the good article icon/template
  1. Edit the template just like any other.

It's possible that this can only be reproduced on Windows, because on my Mac, when I open the page, the template isn't even visible.

Version: unspecified
Severity: normal

Details

Reference
bz70074

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:29 AM
• bzimport added projects: VE-deploy-2014-09-25, VisualEditor-ContentEditable.
• bzimport set Reference to bz70074.
• Whatamidoing-WMF created this task.Aug 27 2014, 12:36 AM
TheDJ added a comment.Aug 27 2014, 9:38 AM

Which browsers are you using ?

• Whatamidoing-WMF added a comment.Aug 27 2014, 3:17 PM

It was reported on Firefox 31 on Windows 7, using Monobook.

There's a screenshot at https://commons.wikimedia.org/wiki/File:VE_with_GA_icon.png

matmarex added a comment.Sep 22 2014, 3:09 PM

Caused by "z-index: 10;" in [[w:en:MediaWiki:Monobook.css]].

matmarex added a comment.Sep 22 2014, 3:16 PM

While this could possibly be fixed on-wiki for this particular case, we should prevent people from accidentally or intentionally breaking this in VE, too.

Esanders added a comment.Sep 22 2014, 3:28 PM

Setting topicons with CSS like this is a horrible hack. Imagine if we did the same with category links!

We should create a simple extension to add topicons to a page, so that they are rendered in the correct place in the HTML (i.e. not the article body). Parsoid can then provide them to VE as metadata and we can handle them accordingly.

I've discussed this with Trevor and Roan and we think it's a fairly simple project to take on.

gerritbot added a comment.Sep 22 2014, 3:30 PM

Change 161957 had a related patch set uploaded by Bartosz Dziewoński:
Prevent page elements from displaying on top of highlights

https://gerrit.wikimedia.org/r/161957

matmarex added a comment.Sep 22 2014, 3:32 PM

Ed, that's bug 23796, with the related bug 51420 in VE.

gerritbot added a comment.Sep 23 2014, 10:06 PM

Change 161957 merged by jenkins-bot:
Prevent page elements from displaying on top of highlights

https://gerrit.wikimedia.org/r/161957

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 1:57 AM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL