Page MenuHomePhabricator
Create Task
Maniphest T72123

VisualEditor redlink detection should obey Title::isAlwaysKnown (so that links to Special pages, EducationProgram pages and GlobalUserPages render correctly)
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Education Programme:

On page
https://pt.wikipedia.org/wiki/User:Alpha_Centaurus?veaction=edit&oldid=39924153&uselang=en
the link to
https://pt.wikipedia.org/wiki/Ensino:Universidade_Federal_do_Rio_Grande_do_Sul/C%C3%A1lculo_Num%C3%A9rico_%28MAT01169%29_%282014-2%29
is red, but it should be blue because (from the user's point of view) the page exists.

GlobalUserPages:

Viewing https://www.mediawiki.org/wiki/Extension:TemplateData shows a blue link for "James Forrester". However, when editing with VisualEditor, the link is red.

See also: T134073: Page curation toolbar should show blue links when there is a global user page

Details

Reference
bz70123
SubjectRepoBranchLines +/-
TitleWidget: Take 'known' status into account when deciding page existencemediawiki/coremaster+23 -4
mw.LinkCache: Links aren't missing if they're knownmediawiki/extensions/VisualEditormaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:33 AM
• bzimport added a project: VisualEditor-MediaWiki.
• bzimport set Reference to bz70123.
He7d3r created this task.Aug 28 2014, 2:04 PM
Jdforrester-WMF added a project: VisualEditor.Nov 24 2014, 4:30 PM
Krenair subscribed.Dec 25 2014, 8:05 PM

Unfortunately, that page doesn't actually exist. EducationProgram just pretends it does via the hook I mentioned in T72504#942697.

Krenair added a project: MediaWiki-extensions-EducationProgram.Dec 25 2014, 8:06 PM
He7d3r updated the task description. (Show Details)Dec 26 2014, 9:58 PM
He7d3r set Security to None.
Krenair mentioned this in T91477: Parsoid rendering shows links to global user pages red instead of blue.Mar 4 2015, 2:36 AM
Jdforrester-WMF renamed this task from Links to existing pages in the Education Program namespaces are marked as red links to VisualEditor's redlink detection doesn't obey TitleIsAlwaysKnown hook, so pages in the Education Program namespaces and GlobalUserPages show up as red.Mar 4 2015, 2:39 AM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF merged a task: T91477: Parsoid rendering shows links to global user pages red instead of blue.
Jdforrester-WMF added subscribers: Krinkle, Aklapper.
Legoktm subscribed.Mar 4 2015, 5:11 AM
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Mar 5 2015, 1:46 AM
Krinkle renamed this task from VisualEditor's redlink detection doesn't obey TitleIsAlwaysKnown hook, so pages in the Education Program namespaces and GlobalUserPages show up as red to VisualEditor redlink detection should obey TitleIsAlwaysKnown hook (so that EducationProgram pages and GlobalUserPage links render correctly).Mar 6 2015, 6:09 AM
Krinkle merged a task: T91731: GlobalUserPage links are red in VisualEditor.
Krinkle added a project: GlobalUserPage.
Krinkle added a subscriber: Eloquence.
Krenair added a comment.Mar 7 2015, 3:09 AM

Extension:WikimediaIncubator also uses this hook so "Valid Wx/xyz info pages should be considered as existing pages". SemanticMediaWiki also uses it for something.

There are other issues due to Title::isAlwaysKnown that aren't just the TitleIsAlwaysKnown hook - existence of files vs. file pages, and existence of system messages.

Jdforrester-WMF raised the priority of this task from Low to Medium.Mar 7 2015, 4:10 AM
Legoktm merged a task: T93227: Links to a user pages that have no local content but get their content from a global user page show as red in VisualEditor but as blue in read mode.Mar 19 2015, 5:56 PM
Legoktm added a subscriber: • Deskana.
Krenair mentioned this in T104604: Check if links on load are 'known' rather than 'exist' locally.Jul 3 2015, 3:30 PM
Jdforrester-WMF added a subtask: T104604: Check if links on load are 'known' rather than 'exist' locally.Jul 3 2015, 3:53 PM
• AKoval_WMF added a subscriber: AndyRussG.Jul 6 2015, 10:18 PM
• AKoval_WMF subscribed.
Jdforrester-WMF closed subtask T104604: Check if links on load are 'known' rather than 'exist' locally as Resolved.Jul 8 2015, 7:34 PM
Krenair mentioned this in T65355: Direct link to a non-extant local file ([[:File:Foo]]) is red even if there is an extant file in a remote repo.Jul 15 2015, 9:07 PM
Liuxinyu970226 subscribed.Jul 21 2015, 4:02 AM
Jdforrester-WMF edited a custom field.Oct 14 2015, 8:45 PM
Catrope mentioned this in T115201: "Talk" tab stays red.Oct 14 2015, 8:48 PM
Krenair renamed this task from VisualEditor redlink detection should obey TitleIsAlwaysKnown hook (so that EducationProgram pages and GlobalUserPage links render correctly) to VisualEditor redlink detection should obey Title::isAlwaysKnown (so that links to Special pages, EducationProgram pages and GlobalUserPages render correctly).Oct 21 2015, 6:49 PM
Krenair merged a task: T116133: When inserting a link to a valid Special:x page via VisualEditor, VisualEditor sometimes says "page does not exist yet".
Krenair added subscribers: Esanders, Dreamyshade.
Jdforrester-WMF merged a task: T116775: Subpages of special pages shouldn't be marked as "redlinks".Oct 27 2015, 4:29 PM
Jdforrester-WMF added a subscriber: Florian.
Krinkle merged a task: T65355: Direct link to a non-extant local file ([[:File:Foo]]) is red even if there is an extant file in a remote repo.Aug 3 2016, 5:25 AM
Krinkle added subscribers: Lokal_Profil, Quiddity, Catrope and 7 others.
Legoktm created subtask T141963: Expose Title::isKnown() status via the API.Aug 3 2016, 7:08 AM

I filed a blocker bug to expose Title::isKnown() via the API, so VE can use it.

Once that is in place, someone will need to update ve.init.mw.LinkCache to use it.

Quiddity mentioned this in T134073: Page curation toolbar should show blue links when there is a global user page.Aug 3 2016, 11:22 PM
Quiddity updated the task description. (Show Details)
Quiddity merged a task: T143814: VisualEditor incorrectly displays pages as red links if they are non-existent but known.Aug 24 2016, 7:45 PM
Quiddity added subscribers: Ijon, • Mattflaschen-WMF.
• AlexMonk-WMF mentioned this in T114798: Use TitleInputWidget in the Score inspector for choosing overriding files.Sep 30 2016, 10:05 PM
Anomie closed subtask T141963: Expose Title::isKnown() status via the API as Resolved.Oct 11 2016, 5:45 PM
gerritbot added a comment.Oct 11 2016, 9:51 PM

Change 315432 had a related patch set uploaded (by Jforrester):
mw.LinkCache: Links aren't missing if they're known

https://gerrit.wikimedia.org/r/315432

gerritbot added a project: Patch-For-Review.Oct 11 2016, 9:51 PM
gerritbot added a comment.Oct 12 2016, 1:05 AM

Change 315455 had a related patch set uploaded (by Alex Monk):
TitleWidget: Take 'known' status into account when deciding page existence

https://gerrit.wikimedia.org/r/315455

gerritbot added a comment.Oct 13 2016, 12:01 AM

Change 315455 merged by jenkins-bot:
TitleWidget: Take 'known' status into account when deciding page existence

https://gerrit.wikimedia.org/r/315455

Jdforrester-WMF closed this task as Resolved.Oct 13 2016, 12:46 AM
Jdforrester-WMF assigned this task to • AlexMonk-WMF.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF moved this task from Freezer to TR1: Releases on the VisualEditor board.
gerritbot added a comment.Oct 13 2016, 12:52 AM

Change 315432 merged by jenkins-bot:
mw.LinkCache: Links aren't missing if they're known

https://gerrit.wikimedia.org/r/315432

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), MW-1.28-release-notes.Oct 13 2016, 1:00 AM
Liuxinyu970226 unsubscribed.Oct 13 2016, 9:25 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL