Page MenuHomePhabricator

ZeroBanner doc still reference X-CS header when it is now X-CS2
Closed, DeclinedPublic

Description

Looking at ZeroBanner source code, it still talk about X-CS header which has been renamed X-CS2. All occurrences probably need to be updated.

$:> grep -r "X-CS" .
./README
./tests/browser/features/banner.feature
./tests/browser/features/step_definitions/banner_steps.rb
./includes/ZeroSpecialPage.php
./includes/PageRendering.php
./includes/ApiZeroBanner.php
./includes/PageRenderingHooks.php


Version: unspecified
Severity: normal

Details

Reference
bz70162

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:35 AM
bzimport added a project: ZeroBanner.
bzimport set Reference to bz70162.
bzimport added a subscriber: Unknown Object (MLST).
Aklapper triaged this task as Lowest priority.Jan 7 2015, 2:30 PM
Aklapper updated the task description. (Show Details)
Aklapper set Security to None.

X-CS is used when communicating with the backend. X-CS2 is purelly for varnish level temp variable (and used in backend for debugging). will need to update the docs

I don't think this is a good GSoC 2015 task. Requires me to simply go through the doc. Explaining it will take much longer for everyone without any clear benefit.

Jdlrobson changed the task status from Open to Stalled.Jun 23 2017, 8:30 PM
Jdlrobson subscribed.

Until we formalise maintaining zero extension

Reedy removed a subscriber: wikibugs-l-list.