Page MenuHomePhabricator

Doxygen: Duplicate anchor LICENSE found
Closed, ResolvedPublic

Description

When setting TAGFILES to use tagfile.xml downloaded from the URL, doxygen 1.7.6.1 gives the following warning: Duplicate anchor LICENSE found

$ grep LICENSE tagfile.xml

<docanchor file="LBFactoryTest_8php">LICENSE</docanchor>
<docanchor file="LBFactoryTest_8php">LICENSE</docanchor>
<docanchor file="LBFactoryTest_8php">LICENSE</docanchor>
<docanchor file="LBFactoryTest_8php">LICENSE</docanchor>
<docanchor file="LBFactoryTest_8php">LICENSE</docanchor>
<docanchor file="LBFactoryTest_8php">LICENSE</docanchor>
<docanchor file="LBFactoryTest_8php">LICENSE</docanchor>

URL: https://doc.wikimedia.org/mediawiki-core/master/php/html/tagfile.xml

Details

Reference
bz70328
Related Gerrit Patches:
mediawiki/core : masterRemove '@section LICENSE'

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:43 AM
bzimport set Reference to bz70328.
bzimport added a subscriber: Unknown Object (MLST).
Nemo_bis created this task.Sep 3 2014, 7:56 AM

Several files define:

  • @section LICENSE

That causes dupes indeed. The @section should probably be removed entirely.

Moving under MediaWiki product.

Wmat added a comment.Nov 19 2014, 3:53 AM

(In reply to Antoine "hashar" Musso (WMF) from comment #1)

Several files define:

  • @section LICENSE

That causes dupes indeed. The @section should probably be removed entirely.
Moving under MediaWiki product.

You mean to just remove the "@section" keyword in each file, not the actual license text, correct?

It's actually not in to many files:
$ grep -ircl "@section LICENSE" *
includes/specials/SpecialFilepath.php
includes/specials/SpecialRedirect.php
includes/debug/logger/legacy/Logger.php
includes/debug/logger/legacy/Spi.php
includes/debug/logger/Logger.php
includes/debug/logger/NullSpi.php
includes/debug/logger/monolog/Processor.php
includes/debug/logger/monolog/Handler.php
includes/debug/logger/monolog/Spi.php
includes/debug/logger/Spi.php
includes/profiler/ProfilerXhprof.php
includes/libs/IPSet.php
includes/libs/ObjectFactory.php
includes/libs/Xhprof.php
maintenance/purgeChangedPages.php
maintenance/purgeChangedFiles.php
tests/phpunit/includes/db/DatabaseMysqlBaseTest.php
tests/phpunit/includes/db/LBFactoryTest.php
tests/phpunit/includes/libs/ObjectFactoryTest.php
tests/phpunit/includes/libs/XhprofTest.php

Change 175932 had a related patch set uploaded (by Krinkle):
Remove '@section LICENSE'

https://gerrit.wikimedia.org/r/175932

Patch-For-Review

Krinkle claimed this task.Nov 26 2014, 2:22 AM
Krinkle updated the task description. (Show Details)
Krinkle set Security to None.
Krinkle removed a subscriber: Unknown Object (MLST).

Change 175932 merged by jenkins-bot:
Remove '@section LICENSE'

https://gerrit.wikimedia.org/r/175932

For quite a few files the license block is appearing as the brief description in Doxygen's file list. Maybe put @copyright or something before the text and/or add an actual brief description to fix that?

Also, @section LICENSE is mentioned in https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP#Source_file_headers. Perhaps correct that example?