VisualEditor: Link, Formula and Text Styles etc. should be disabled when focus is inside the comment/gallery/math/hieroglypics/… editors
Open, LowPublic8 Story Points

Description


1> open a page in VE, insert a comment.
2> Click to edit the comment and insert a link. Notice the link icon is selected in the toolbar, although no link gets inserted in the comment . Try the above steps, with Formula and text styles like Underline, Strikethrough. See screenshots.

Details

Reference
bz70343
bzimport raised the priority of this task from to Low.
bzimport set Reference to bz70343.
Swainr created this task.Sep 3 2014, 2:53 PM
Swainr added a comment.Sep 3 2014, 2:53 PM

Created attachment 16353
screenshot2

Attached:

Swainr added a comment.Sep 3 2014, 3:15 PM

Environment-test2

Confirmed - as the attached screenshots indicate - link, and some style formats - e.g. Bold, Italic, Underline - make an impression that they can be applied to Comments or Formulas.

IN fact, clicking Formatting options or insert link have no effect on inserted Comments or Formulas.

Jdforrester-WMF renamed this task from VisualEditor: Link, Formula and Text Styles etc. should be disabled when focus is inside the comment editor to VisualEditor: Link, Formula and Text Styles etc. should be disabled when focus is inside the comment/gallery/math/hieroglypics/… editors.Sep 17 2015, 5:50 PM
Jdforrester-WMF set Security to None.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2015, 5:50 PM
Jdforrester-WMF edited a custom field.

Inspectors are non-modal so opening them keeps the selection in the surface, and so you can still use all the tools.

Disabling the tools would suggest that the surface selection is no longer active which is not true.

I disagree. Disabling the surface (greyed out, like we do for dialogs) suggests the surface isn't active. Disabling individual tools (greyed out, like we do when the selection is a table range) suggests the tool can't work where the user believes the cursor is currently.