Page MenuHomePhabricator

Post-edit recommendations fail to show
Closed, ResolvedPublic

Description

Steps to reproduce:

0. Go to en.wikipedia.beta.wmflabs.org

  1. Log into an account with a user_id where mod 4 results in 1.
  2. Go to http://en.wikipedia.beta.wmflabs.org/wiki/0.5841116106330823
  3. edit the page and click save
  4. See no post-edit -- console shows "Uncaught TypeError: Cannot read property 'setId' of undefined"

Version: unspecified
Severity: normal

Details

Reference
bz70350

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:45 AM
bzimport set Reference to bz70350.
Halfak created this task.Sep 3 2014, 4:12 PM
phuedx added a comment.Sep 3 2014, 4:26 PM

This is caused by the gettingstartedgetpages returning an empty array - the request doesn't fail, but there are no results returned. I thought we'd dealt with this, but clearly haven't.

gerritadmin wrote:

Change 158131 had a related patch set uploaded by Phuedx:
Fix post-edit TaskRecommendationImpression logging

https://gerrit.wikimedia.org/r/158131

gerritadmin wrote:

Change 158131 merged by jenkins-bot:
Fix post-edit TaskRecommendationImpression logging

https://gerrit.wikimedia.org/r/158131

Confirmed fixed.