Page MenuHomePhabricator

LQT: Thread summary element should contain any floated content
Open, LowestPublic

Description

Screenshot of bug.

When the thread summary contains floated content (e.g. on mediawiki.org the [[mw:Template:Tracker]] template), the post body is oddly narrow due to it being stuck behind that float.

This itself is a consequence of it using display:table, but there's probably a strange reason for that.


Version: unspecified
Severity: normal

Attached:

lqt-bug.png (652×1 px, 160 KB)

Details

Reference
bz70367

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:46 AM
bzimport set Reference to bz70367.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 16359
Screenshot of proposed fix.

Let's add overflow: hidden; to .lqt_thread_permalink_summary_body so that any float is cleared before other block elements start.

This also has a nice side-effect of ensuring the background color and border around the summary area goes around the floated content to properly contain it.

Attached:

lqt-bug-fixed.png (888×2 px, 246 KB)

Jdforrester-WMF lowered the priority of this task from Medium to Lowest.Aug 4 2016, 11:33 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

LiquidThreads has been replaced by StructuredDiscussions on all Wikimedia production wikis (except one, which will be done soon). It is no longer under active development or maintenance, so I'm re-classifying all open LQT tasks as "Lowest" priority.