Page MenuHomePhabricator

[l10n] Use Scap in Localisation Update
Closed, ResolvedPublic

Description

Currently, it just iterates over the lot, it'd be nice (for l10nupdate usages) if we could pass a parameter to scap-rebuild-cdbs of the mediawiki version to rebuild

  1. Rebuild the CDB files from the JSON versions for version, wikidb in self.active_wikiversions().items(): cache_dir = os.path.join(self.config['deploy_dir'], 'php-%s' % version, 'cache', 'l10n') tasks.merge_cdb_updates( cache_dir, use_cores, True, self.arguments.mute)

Version: unspecified
Severity: normal

Details

Reference
bz70443

Revisions and Commits

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:51 AM
bzimport added a project: Deployments.
bzimport set Reference to bz70443.

As a no-op for a version, it's still a tonne quicker than the current method (see https://gerrit.wikimedia.org/r/#/c/158623 for improvements), so running the extra iterations isn't the biggest issue.

On second thought, is this worth doing? Should I just rework the script so that it does the 3 rebuilds, syncs, and then does just one call to rebuild the cdbs?

https://github.com/wikimedia/operations-puppet/blob/production/files/misc/l10nupdate/l10nupdate-1#L68-L111

That block could nearly just be replaced with a scap call, couldn't it?

The only real difference is the LocalisationUpdate call out (at a quick glance, scap doesn't do anything with LU currently) https://github.com/wikimedia/operations-puppet/blob/production/files/misc/l10nupdate/l10nupdate-1#L87-L89

The updating of the source repos needs to be done first (so that can stay for now), and then the refresh of the RL cache needs doing after...

gerritadmin wrote:

Change 158623 had a related patch set uploaded by Greg Grossmeier:
Use sync-dir to copy out l10n json files, build cdbs on hosts

https://gerrit.wikimedia.org/r/158623

gerritadmin wrote:

Change 158623 merged by Springle:
Use sync-dir to copy out l10n json files, build cdbs on hosts

https://gerrit.wikimedia.org/r/158623

greg removed Reedy as the assignee of this task.Mar 27 2015, 7:31 PM
greg set Security to None.
bd808 claimed this task.

{{done}}

greg raised the priority of this task from Medium to Unbreak Now!.Apr 16 2015, 4:22 PM
greg moved this task from In-progress to Done on the Deployments board.
greg lowered the priority of this task from Unbreak Now! to Medium.Apr 16 2015, 4:25 PM