Page MenuHomePhabricator

HTMLMultiSelectField checkboxes do not use MW UI
Closed, ResolvedPublic

Description

The checkboxes at http://mwui.wmflabs.org/wiki/Special:EditWatchlist
are not styled


Version: unspecified
Severity: normal

Details

Reference
bz70473

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:53 AM
bzimport set Reference to bz70473.
Quiddity created this task.Sep 6 2014, 3:51 AM

Thanks for the report. The underlying code has a TODO, but this will help track it better.

Special:EditWatchlist uses EditWatchlistCheckboxSeriesField, which extends HTMLMultiSelectField.

HTMLMultiSelectField has a TODO to use checkLabel. I'll make this bug about that class.

(In reply to Matthew Flaschen from comment #1)

HTMLMultiSelectField has a TODO to use checkLabel. I'll make this bug about
that class.

I wondering, if checkLabel can be used there. The label is html content (the link to the page), and checkLabel will escape all html code from label.

And HTMLMultiSelectField has a check for UseMediaWikiUIEverywhere, this should be removed to use mw ui all the time, right? :)

Fixed by Prateek in 358d2980cc6c817e727dfaf166bf975a57f20950 and 9b461e218ad9b804435ef3e99bdedfd3759e02d7

(In reply to Florian from comment #2)

(In reply to Matthew Flaschen from comment #1)

HTMLMultiSelectField has a TODO to use checkLabel. I'll make this bug about
that class.

I wondering, if checkLabel can be used there. The label is html content (the
link to the page), and checkLabel will escape all html code from label.

Yeah, maybe not. There is some trickiness in this class's labels, which is why it doesn't already use checkLabel.

And HTMLMultiSelectField has a check for UseMediaWikiUIEverywhere, this
should be removed to use mw ui all the time, right? :)

Yes, I want to get rid of UseMediaWikiUIEverywhere entirely as soon as we're ready (using the true behavior always).