Page MenuHomePhabricator

GlobalUserPage: Improve border around footer
Open, LowPublic

Description

From bug 70576 comment 4 by Isarra:

I still don't like that border. #aaa is awfully dark when it's just white
all around on both sides, especially in skins like vector with a lot of much
more subtle colour transitions. The appearance in others could be
subsequently HORRIBLE but that doesn't really apply to wikimedia.

Is there really no generic core class for this kind of thing where you can
just apply to the new stuff like this? Be something toc, editoptions,
categories, and anything else along those lines would also use, such that
they all automatically match regardless of skin, or origin? Seems like that
would be neater.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=66931

Details

Reference
bz70629

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:47 AM
bzimport added a project: GlobalUserPage.
bzimport set Reference to bz70629.
bzimport added a subscriber: Unknown Object (MLST).
Legoktm created this task.Sep 9 2014, 9:02 PM

Note: Support for the footer was added in bug 66931 and https://gerrit.wikimedia.org/r/158605

The reason I chose #aaa as the border color in the mockup suggested there, is that it matches the #aaa currently used in: Infoboxes, all Mboxes, the ToC border, the category box border, and the H1/H2 underline.
cf. https://en.wikipedia.org/wiki/MediaWiki:Common.css etc

One option, would be to add a background color to the box. The standard is #F9F9F9. (I'm not sure why I didn't use that in my mockup?!). I'd recommend adding that.

#aaa does tend to work a lot better when the background colour is also changed, yeah. By itself it stands out (on white) as much too harsh and dark.

So yeah, do thatn but is there seriously no common class that the other things use? Why the hell not?

Bastardly elements.

Aklapper triaged this task as Lowest priority.Dec 31 2014, 1:58 PM
Aklapper added a subscriber: Aklapper.

Why can't we just remove the border and make the text in italic? That's the MediaWiki core default for remote repositories (example).

Nemo_bis raised the priority of this task from Lowest to Low.Jan 30 2015, 10:03 AM
Nemo_bis set Security to None.

Why can't we just remove the border and make the text in italic? That's the MediaWiki core default for remote repositories (example).

There is not a single <i> or <em> on that page (aside from the _Unicode_ tagline transcluded from Commons).

The default message for this sort of thing in MediaWiki has no styling. E.g.

This file is from Wikimedia Commons and may be used by other projects. The description on its file description page there is shown below.

https://www.mediawiki.org/wiki/File:Example.svg
https://github.com/wikimedia/mediawiki/blob/3240b71f/languages/i18n/en.json#L1462-L1466
https://github.com/wikimedia/mediawiki/blob/dd8c1e2dd/includes/page/ImagePage.php#L646-L649

Classes available in MediaWiki suitable for this purpose:

  • toccolours
  • mw-warning

Either seem like a good fit. mw-warning seems a little better as it has additional left/right margin and centres the text.

There is not a single <i> or <em> on that page (aside from the _Unicode_ tagline transcluded from Commons).

.sharedUploadNotice {
    font-style: italic;
}

There is not a single <i> or <em> on that page (aside from the _Unicode_ tagline transcluded from Commons).

.sharedUploadNotice {
    font-style: italic;
}

Only in oldshared.css (legacy, used by CologneBlue and Nostalgia). Not part of shared.css, Vector, or MonoBook :)

@violetto @Jaredzimmerman-WMF @Prtksxna please help evolve the standard recommended styles for these types of in-page notices and ensure they're part of our style guide, thanks.

Nemo_bis added a comment.EditedFeb 24 2015, 8:47 AM

Only in oldshared.css (legacy, used by CologneBlue and Nostalgia). Not part of shared.css, Vector, or MonoBook :)

I don't know of what release you're talking (the wiki was upgraded few days ago), but in monobook the file description definitely has italic as of 1.24. I can attach a screenshot if needed. :) https://commons.wikimedia.org/wiki/File:InstantCommons_1.24_monobook.png