Page MenuHomePhabricator

Convert ApiQueryExtLinksUsage to use Config instead of globals
Closed, ResolvedPublic

Description

ApiQueryExtLinksUsage::prepareProtocols() and getProtocolPrefix() are both reading from $wgUrlProtocols directly. They're both static since they're being used in ApiQueryExternalLinks as well.


Version: 1.24rc
Severity: normal

Details

Other Assignee
tchin
Reference
bz70632

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:47 AM
bzimport set Reference to bz70632.
bzimport added a subscriber: Unknown Object (MLST).
xSavitar assigned this task to Reedy.
xSavitar updated Other Assignee, added: tchin.
xSavitar subscribed.

I think @Reedy covered some of this in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/109271 (2014). Then in 2022, the rest was covered by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/740663.

We can close this task as resolved.