WikibasePage.toJSON depends on collections.Counter, which is only available in py2.7.
WikibasePage.editEntity with data=None uses is the only current caller of WikibasePage.toJSON. This is new functionality, unavailable in compat, so a py 2.7 requirement is not a breaking change.
Severity: minor
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| pywikibot/core | master | +1 -3 | WikibasePage.editEntity() no longer requires python 2.7 | |
| pywikibot/core | master | +69 -59 | Python 2.6 collections backports & failover |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Invalid | None | T72987 Python 2.6 issues (tracking) | |||
| Resolved | jayvdb | T72707 editEntity using site object depends on py2.7 |
Change 159700 had a related patch set uploaded by John Vandenberg:
Require 2.7+ for one wikibase test
There is https://pypi.python.org/pypi/Counter/1.0.0 which could be used in 2.6 or we use the recipy directly http://code.activestate.com/recipes/576611-counter-class/
Indeed. Whereas we knew we needed a backport of OrderedDict for non-Wikibase needs, collections.Counter is so far only needed for Wikibase functionality not available previously or in compat, so we dont need to maintain backwards compatibility. This bug is to ensure it can be found easily. If there are py2.6 users of core needing this, we need to know who they are and why.
Change 147665 had a related patch set uploaded (by John Vandenberg):
Python 2.6 collections backports & failover
Change 200925 had a related patch set uploaded (by Nemo bis):
WikibasePage.editEntity() no longer requires python 2.7
Change 200925 merged by jenkins-bot:
WikibasePage.editEntity() no longer requires python 2.7