Page MenuHomePhabricator

editEntity using site object depends on py2.7
Closed, ResolvedPublic

Description

WikibasePage.toJSON depends on collections.Counter, which is only available in py2.7.

WikibasePage.editEntity with data=None uses is the only current caller of WikibasePage.toJSON. This is new functionality, unavailable in compat, so a py 2.7 requirement is not a breaking change.


Severity: minor

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 3:52 AM
bzimport set Reference to bz70707.
bzimport added a subscriber: Unknown Object (????).

Change 159700 had a related patch set uploaded by John Vandenberg:
Require 2.7+ for one wikibase test

https://gerrit.wikimedia.org/r/159700

Indeed. Whereas we knew we needed a backport of OrderedDict for non-Wikibase needs, collections.Counter is so far only needed for Wikibase functionality not available previously or in compat, so we dont need to maintain backwards compatibility. This bug is to ensure it can be found easily. If there are py2.6 users of core needing this, we need to know who they are and why.

Change 159700 merged by jenkins-bot:
Require 2.7+ for one wikibase test

https://gerrit.wikimedia.org/r/159700

gerritbot added a subscriber: gerritbot.

Change 147665 had a related patch set uploaded (by John Vandenberg):
Python 2.6 collections backports & failover

https://gerrit.wikimedia.org/r/147665

Patch-For-Review

Change 147665 merged by jenkins-bot:
Python 2.6 collections backports & failover

https://gerrit.wikimedia.org/r/147665

jayvdb claimed this task.

Change 200925 had a related patch set uploaded (by Nemo bis):
WikibasePage.editEntity() no longer requires python 2.7

https://gerrit.wikimedia.org/r/200925

Ricordisamoa removed a subscriber: Unknown Object (MLST).

Change 200925 merged by jenkins-bot:
WikibasePage.editEntity() no longer requires python 2.7

https://gerrit.wikimedia.org/r/200925