Do not load full entities when invoking LinkBegin hook
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aude
	Sep 12 2014, 11:40 AM

Description

We load full entities for the onLinkBegin hook handler in Wikibase Repo in order to get a label.

e.g. for each item or property on Special:Allpages, we load the entity to get the label.

a term lookup, with caching and all, should be used instead.

LinkBegin is also used in places like Special:Watchlist (i think), so if someone has a gigantic watchlist, it probably will timeout.

Version: unspecified
Severity: normal
Whiteboard: u=dev c=backend p=8 s=2014-11-11

Details

Reference: bz70767

Subject	Repo	Branch	Lines +/-
Use TermLookup in LinkBegin hook	mediawiki/extensions/Wikibase	master	+227 -117
Use wb_terms table for label lookup.	mediawiki/extensions/Wikibase	master	+2 -1
Use TermLookup in LinkBegin hook.	mediawiki/extensions/Wikibase	master	+323 -184

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Duplicate	None	T72716 cannot save badges on Q183 (Germany)
Resolved	None	T73519 Unblock editing the item for Germany (Q183) (Was: Wikimedia Error page on)
Resolved	daniel	T72767 Do not load full entities when invoking LinkBegin hook
Resolved	None	T73169 Implement terms-lookup based on terms-table
Resolved	daniel	T70026 Create EntityFingerprintLookup service for use with EntityLabelFormatter and simmilar classes.
Resolved	daniel	T74309 Investigate how prefetching labels would work for watchlist and recent changes
Open	None	T76159 [Task] Preload labels and descriptions for Lua and the parser function based on usage tracking data
Resolved	hoo	T75460 [Story] Make Lua functions default to the user's language on multilingual wikis
Resolved	Wikidata-bugs	T75888 Use EntityIdFormatter for PropertyLabels in ClaimHtmlFormatter
Resolved	Lydia_Pintscher	T75744 Use EntityInfoTermLookup / label lookup in ClaimsView and SnakHtmlGenerator for formatting property ids

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:56 AM

• bzimport added a project: MediaWiki-extensions-WikibaseRepository.

• bzimport set Reference to bz70767.

• bzimport added a subscriber: Unknown Object (MLST).

aude created this task.Sep 12 2014, 11:40 AM

part of the solution to this is to avoid using Linker whenever possible.

We are currently using Linker to format property id links in ClaimsView and SnakHtmlGenerator. Instead we should use an EntityIdHtmlLinkFormatter that makes use of an EntityInfoTermLookup / LabelLookup for this.

by not using Linker, we don't encounter this hook.

aude mentioned this in T75683: Factor out onLinkBegin hook handling code into separate class, with tests.Nov 23 2014, 12:06 AM

aude mentioned this in T75684: [Task] Use batching label lookup in SpecialWikibaseQueryPage.

Liuxinyu970226 subscribed.Nov 24 2014, 10:19 AM

aude mentioned this in T75744: Use EntityInfoTermLookup / label lookup in ClaimsView and SnakHtmlGenerator for formatting property ids.Nov 24 2014, 3:42 PM

Change 176650 had a related patch set uploaded (by Daniel Kinzler):
Use wb_terms table for label lookup.

https://gerrit.wikimedia.org/r/176650

Patch-For-Review