Page MenuHomePhabricator

Don't emit data-parsoid attributes for template content
Closed, ResolvedPublic

Description

Either strip this as part of the cleanup pass or don't save it during the saveDataParsoid pass, or some such thing.


Version: unspecified
Severity: normal

Details

Reference
bz70786

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:57 AM
bzimport added a project: Parsoid-DOM.
bzimport set Reference to bz70786.

Change 160698 had a related patch set uploaded by Marcoil:
Bug #70786: Don't emit data-parsoid attributes for template content

https://gerrit.wikimedia.org/r/160698

Change 160698 merged by jenkins-bot:
Bug #70786: Don't emit data-parsoid attributes for template content

https://gerrit.wikimedia.org/r/160698

This has been disabled in production, pending further discussion with Parsoid users (like Flow) which could depend on data-parsoid being present.

AFAIK, the only blocker right now is the use of data-parsoid StructuredDiscussions makes.

(And if I got Phab correctly, mentioning them here should summon them from the darkness ;)

flow reads the data-parsoid for one case, which is solved in this parsoid patch: https://gerrit.wikimedia.org/r/#/c/170455/

Whenever that is merged you can go ahead and strip the data-parsoid attributes.

Change 178574 had a related patch set uploaded (by Marcoil):
T72786: Re-enable stripping data-parsoid for template content

https://gerrit.wikimedia.org/r/178574

Patch-For-Review

Change 178574 merged by jenkins-bot:
T72786: Re-enable stripping data-parsoid for template content

https://gerrit.wikimedia.org/r/178574

Arlolra subscribed.