Page MenuHomePhabricator

Flow: highlight the response in the notification more than newer notifications
Open, LowPublic

Description

proposed highlight response specially from newer posts

When I click an Echo notification like

Topic name
198.73.209.2 responded on Talk:Flow.
NN days ago

I'm taken to a URL like
http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Topic:Ryngpk7gt93ir9of&fromnotif=1#flow-post-s0fkp8hb9arpbf0y
The fragment makes the topic scroll to that specific response, and the fromnotif=1 makes Flow highlight this post and all posts newer than it.

This is a great feature, but it's hard to distinguish the specific response from the mass of newer posts. We should keep the permalink behavior of highlighting the response post specially. Compare the URL above with the Permalink URL:
http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Topic:Ryngpk7gt93ir9of#flow-post-s0fkp8hb9arpbf0y

If you add class 'flow-post-highlighted' to the specific post and only add class 'flow-post-highlight-newer' to the newer posts (which makes more semantic sense), you get the effect in the attached screenshot. I don't know if we should adjust this when bundling notifications.


Version: master
Severity: enhancement

Attached:

Details

Reference
bz70800

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:58 AM
bzimport set Reference to bz70800.
bzimport added a subscriber: Unknown Object (MLST).

We think that this is not a problem for the reply notification (since it's a roll-up notification, thus it's highlighting only desired posts anyway), but it is a problem for other types (e.g. mentions).