Page MenuHomePhabricator

checkboxes hover, focus, and click states are not to spec
Closed, DuplicatePublic

Description

currently checkboxes do not carry the bottom border on hover, only on focus.

additionally when clicked (active) the bottom border disappears.

The check mark is only supposed to be green when the both checked and hovered

border colors are inconsistent with unfocused input fields (too dark)


Version: unspecified
Severity: normal
URL: https://trello.com/c/JETLmm7F/7-check-boxes

Details

Reference
bz70909

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:48 AM
bzimport set Reference to bz70909.
bzimport added a subscriber: Unknown Object (MLST).

gerritadmin wrote:

Change 161261 had a related patch set uploaded by Prtksxna:
checkbox.less: images

https://gerrit.wikimedia.org/r/161261

(In reply to Jared Zimmerman (WMF) from comment #0)

currently checkboxes do not carry the bottom border on hover, only on focus.

Can you update mw.ui.checkbox.fw.png at https://trello.com/c/JETLmm7F/7-check-boxes ? Currently it doesn't mention hover at all.

It would be good to visually distinguish between the hover and focus states.

additionally when clicked (active) the bottom border disappears.

I assume active is the same as focused.

The check mark is only supposed to be green when the both checked and
hovered

The mockup shows it green on focus.

focus = hover in this case. We're handling the keyboard/accessibility focus in a separate bug.

gerritadmin wrote:

Change 161261 abandoned by Prtksxna:
checkbox.less: Fix checkbox states

Reason:
Too out of date.

https://gerrit.wikimedia.org/r/161261

@violetto Could you please update the task to the current state and outline the requirements still missing.