| • Mattflaschen-WMF | |
| Sep 17 2014, 12:38 AM |
| F165404: pasted_file | |
| May 16 2015, 5:17 PM |
| F14908: Contributions_page_with_MediaWiki_UI.png | |
| Dec 3 2014, 12:01 PM |
| F14909: Contributions_page_with_MediaWiki_UI_(after_code_update).png | |
| Nov 22 2014, 3:48 AM |
Special:Contributions with wgUseMediaWikiUIEverywhere = true
When wgUseMediaWikiUIEverywhere is true, the Contributions special page doesn't have correct margins between different form elements. This is most noticeable between "Only show edits that are latest revisions", and the checkbox to its right, which corresponds to "Only show edits that are page creations"
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | • Mattflaschen-WMF | T99211 Eliminate $wgUseMediaWikiUIEverywhere, leaving 'on' behavior | |||
| Declined | • Mattflaschen-WMF | T72424 Set $wgUseMediaWikiUIEverywhere = true | |||
| Declined | None | T72913 Remove $wgUseMediaWikiUIEverywhere dependency for button and text input styling | |||
| Declined | • Mattflaschen-WMF | T72920 Special:Contributions margin between form elements is incorrect with MediaWiki UI |
I believe https://gerrit.wikimedia.org/r/#/c/154125/ fixes this. It's been sitting around for a while so I'd appreciate the review!
It's now more readable in some ways, but less in others (I'll add an attachment right after this post).
There's no more space between checkbox+label sets, including the example I mentioned in the original report, which is good.
However, there's still more between a checkbox and its associated label. For example, there is more space between the "Only show edits that are latest revisions" checkbox and the "Only show edits that are latest revisions" label than between the two independent sets.
It's important that there be a close association between the checkbox and its label. The distance between separate sets can be a little greater, in my opinion.
Without the new global (https://en.wikipedia.org/wiki/Special:Contributions), it looks like the two distances are roughly the same (the between-set difference could be higher). The distance between a checkbox and its label is lower than with MW UI, which is good. I realize there's an argument the distance should be higher because of the larger checkbox, but it seems too big (and the ratio of the two distance seems wrong) even taking that into account.
(In reply to Matthew Flaschen from comment #2)
There's no more space between checkbox+label sets, including the example I
mentioned in the original report, which is good.
Sorry, I mean "There's now more space".
The main issue I see with the above screenshot (from the user perspective) is the select menu's which would be helped by switching those to non-native styles e.g. oojs-ui or mw-ui-
