Page MenuHomePhabricator

Gallery with packed mode does not update image height and width to be consistent after resize
Open, NormalPublic

Description

see https://www.mediawiki.org/wiki/Design#Team (https://www.mediawiki.org/w/index.php?title=Design&oldid=1267210#Team) reload the page at different browser widths to see images size inconsistant ways per page load, even when the syntax specifies the heights absolutely.


Version: unspecified
Severity: normal

Details

Reference
bz70926

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:49 AM
bzimport added a project: MediaWiki-General.
bzimport set Reference to bz70926.
bzimport added a subscriber: Unknown Object (MLST).

Seeing six photos in the first row and five in the second, both rows having the same total width, this might simply be a feature?

<li class="gallerybox" style="width: 178.8333px;"></li> (first row)
<li class="gallerybox" style="width: 217.946px;"></li> (second row)

for my screen with 1440px width.

  • Bug 70925 has been marked as a duplicate of this bug. ***

doesn't *feel* like a feature, especially when you resize you browser and you see things lot line up.

Its a feature that the heights are adaptive (in the packed mode) to fill width of screen, and that different rows will have different heights in order that the rows "line-up".

In the particular page you have, I'll admit that it might look good for both rows to have same height, and have the last row centered. However the general case of having many rows, it usually looks better to have all rows with the same combined width, but varying the heights for each row.


It is a known shortcoming that the heights only re-adjust at the initial page load, and if you re-size your browser window after the page has loaded, everything goes to crap.

Note: That in the docs for this feature, it says that the heights parameter is only strictly interpreted for mode="traditional".

Would it be possible for the heights to be adjusted dynamically per row, rather than just during page load, this would resolve the issue with inconsistent heights in the same row.

Its possible, involves more than a couple line fix though. Would require someone to actually do it(tm), but definitely doable.

Qgil edited projects, added Multimedia; removed MediaWiki-General.Mar 20 2015, 6:18 PM
Qgil set Security to None.
Tgr renamed this task from Gallery element renders image height and width inconsistently when you specify packed mode to Gallery with packed mode does not update image height and width to be consistent after resize.Mar 20 2015, 8:36 PM
Tgr added a project: JavaScript.
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:25 PM
Restricted Application added subscribers: Matanya, Aklapper. · View Herald TranscriptSep 4 2015, 6:25 PM
Prtksxna added a subscriber: Prtksxna.EditedJun 19 2016, 5:07 AM

I am not able to reproduce this issue, was it fixed? Or maybe as part of T55664: New-style packed gallery shows ragged edges after window resize?

When I resize the window the heights do get adjusted on the old design page.

Are there other ways to reproduce the issue?

Prtksxna updated the task description. (Show Details)Jun 19 2016, 5:08 AM