Page MenuHomePhabricator

Thumbnails not shown in Special:ListFiles when using Postgres
Closed, ResolvedPublic

Description

Author: gebhkla

Description:
In Special:ListFiles the column Thumbnail is not showing the thumbnail, instead the name is shown. This is because the timestamp used as option for the method findFile uses a different format, than the method expects:

We fixed this behaviour by replacing line 409 in SpecialListfiles.php:

$opt = array( 'time' => $this->mCurrentRow->img_timestamp );

with:

$opt = array( 'time' => wfTimestamp( TS_MW, strtotime( $this->mCurrentRow->img_timestamp ) ) );


Version: 1.22.5
Severity: normal

Details

Reference
bz70931

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Low.
bzimport set Reference to bz70931.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.Sep 17 2014, 8:34 AM

gebhkla wrote:

We have noticed the same problem with 1.23.0 and the fixed the same way.

Thanks for taking the time to report this!
Trying the *latest* 1.23.x or 1.22.x versions is highly welcome.

Reedy added a comment.Sep 17 2014, 4:32 PM

(In reply to Andre Klapper from comment #2)

Thanks for taking the time to report this!
Trying the *latest* 1.23.x or 1.22.x versions is highly welcome.

The code is exactly the same on master, just at line 425... It's not a formatted timestamp, so it definitely needs something doing with it...

Change 192456 had a related patch set uploaded (by Jjanes):
PostgreSQL: Fix timestamp in Special:ListFiles

https://gerrit.wikimedia.org/r/192456

Patch-For-Review

Umherirrender set Security to None.

Change 192456 merged by jenkins-bot:
PostgreSQL: Fix timestamp in Special:ListFiles

https://gerrit.wikimedia.org/r/192456

Umherirrender closed this task as Resolved.Feb 26 2015, 8:01 PM
Umherirrender added a subscriber: Umherirrender.

Will be fixed with version 1.25, maybe backported if the backport request gets approved by the release team.

Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Migrating from the old tracking task to a tag for PostgreSQL-related tasks.