Page MenuHomePhabricator

Investigate issues with globe coordinate precision
Closed, ResolvedPublic

Description

See https://bugzilla.wikimedia.org/show_bug.cgi?id=64820 and https://bugzilla.wikimedia.org/show_bug.cgi?id=66653


Version: unspecified
Severity: normal
Whiteboard: u=dev c=backend p=5 s=2014-09-23

Details

Reference
bz70934

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:49 AM
bzimport set Reference to bz70934.
bzimport added a subscriber: Unknown Object (MLST).

result of the investigation:

The GlobeCoordinateFormatter does not pass the precision stored in the GlobeCoordinateValue to the GeoCoordinateFormatter. The GeoCoordinateFormatter interprets the precision as the number of decimal places to show (in whatever the target format is). However, GlobeCoordinateParser generates precision values as fractions of a degree.

To fix this, we have to:

  1. change GeoCoordinateFormatter to interpret the precision option as a fraction of a degree.
  2. change GlobeCoordinateFormatter to pass precision from the the GlobeCoordinateValue to the GeoCoordinateFormatter.
  3. write round trip tests to assert parser and formatter are compatible.