Page MenuHomePhabricator

Issues with IE8 JavaScript due to use of indexOf - stops search from working
Closed, ResolvedPublic

Description

JS exceptions are thrown in IE8
I believe this is due to use of Array.prototype.indexOf not supported in IE8
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/indexOf

Webpage error detailsUser Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.0; Trident/4.0; SLCC1; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729)Timestamp: Wed, 17 Sep 2014 21:24:05 UTCMessage: Object doesn't support this property or methodLine: 302Char: 3Code: 0URI: http://127.0.0.1:8080/w/load.php?debug=true&lang=en&modules=mobile.head&only=scripts&skin=minerva&version=20140917T211859Z&*Message: Object doesn't support this property or methodLine: 933Char: 2Code: 0URI: http://127.0.0.1:8080/w/load.php?debug=true&lang=en&modules=mobile.startup&only=scripts&skin=minerva&version=20140917T211924Z&*Message: Object doesn't support this property or methodLine: 2Char: 2Code: 0URI: http://127.0.0.1:8080/w/extensions/MobileFrontend/javascripts/modules/toggling/toggle.jsMessage: Module not found: ViewLine: 53Char: 4Code: 0URI: http://127.0.0.1:8080/w/load.php?debug=true&lang=en&modules=mobile.head&only=scripts&skin=minerva&version=20140917T211859Z&*Message: 'undefined' is null or not an objectLine: 32Char: 2Code: 0URI: http://127.0.0.1:8080/w/extensions/MobileFrontend/javascripts/loggingSchemas/MobileWebClickTracking.jsMessage: Module not found: OverlayLine: 53Char: 4Code: 0URI: http://127.0.0.1:8080/w/load.php?debug=true&lang=en&modules=mobile.head&only=scripts&skin=minerva&version=20140917T211859Z&*Message: Module not found: OverlayLine: 53Char: 4Code: 0URI: http://127.0.0.1:8080/w/load.php?debug=true&lang=en&modules=mobile.head&only=scripts&skin=minerva&version=20140917T211859Z&*Message: Module not found: OverlayLine: 53Char: 4Code: 0URI: http://127.0.0.1:8080/w/load.php?debug=true&lang=en&modules=mobile.head&only=scripts&skin=minerva&version=20140917T211859Z&*Message: Module not found: LoadingOverlayLine: 53Char: 4Code: 0URI: http://127.0.0.1:8080/w/load.php?debug=true&lang=en&modules=mobile.head&only=scripts&skin=minerva&version=20140917T211859Z&*Message: Module not found: toastLine: 53Char: 4Code: 0URI: http://127.0.0.1:8080/w/load.php?debug=true&lang=en&modules=mobile.head&only=scripts&skin=minerva&version=20140917T211859Z&*Message: Module not found: DrawerLine: 53Char: 4Code: 0URI: http://127.0.0.1:8080/w/load.php?debug=true&lang=en&modules=mobile.head&only=scripts&skin=minerva&version=20140917T211859Z&*Message: Module not found: ViewLine: 53Char: 4Code: 0URI: http://127.0.0.1:8080/w/load.php?debug=true&lang=en&modules=mobile.head&only=scripts&skin=minerva&version=20140917T211859Z&*Message: Module not found: modules/tutorials/PageActionOverlayLine: 53Char: 4Code: 0URI: http://127.0.0.1:8080/w/load.php?debug=true&lang=en&modules=mobile.head&only=scripts&skin=minerva&version=20140917T211859Z&*Message: Module not found: ViewLine: 53Char: 4Code: 0URI: http://127.0.0.1:8080/w/load.php?debug=true&lang=en&modules=mobile.head&only=scripts&skin=minerva&version=20140917T211859Z&*Message: Module not found: modules/uploads/LeadPhotoUploaderButtonLine: 53Char: 4Code: 0URI: http://127.0.0.1:8080/w/load.php?debug=true&lang=en&modules=mobile.head&only=scripts&skin=minerva&version=20140917T211859Z&*Message: Module not found: OverlayLine: 53Char: 4Code: 0URI: http://127.0.0.1:8080/w/load.php?debug=true&lang=en&modules=mobile.head&only=scripts&skin=minerva&version=20140917T211859Z&*


Version: unspecified
Severity: normal

Details

Reference
bz70963

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:51 AM
bzimport set Reference to bz70963.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/Hjyc5lIg

Change 162176 had a related patch set uploaded by Jdlrobson:
Switch to using $.inArray instead of indexOf for arrays

https://gerrit.wikimedia.org/r/162176

Change 162176 merged by jenkins-bot:
Switch to using $.inArray instead of indexOf for arrays

https://gerrit.wikimedia.org/r/162176