Page MenuHomePhabricator

CSSMin: Don't generate double rules for IE < 8 when embedding SVG files
Closed, ResolvedPublic

Description

CSSMin doesn't need to generate double rules for IE<8 when embedding SVG files. IE<8 will not load SVG images anyway, so this just wastes space.

This if() in CSSMin.php probably should have a test added for SVG MIME type.

if ( $embedData && $ruleWithEmbedded !== $ruleWithRemapped ) {
  return "$ruleWithEmbedded;$ruleWithRemapped!ie";
} else {
  return $ruleWithRemapped;
}

Version: 1.24rc
Severity: minor

Details

Reference
bz71003

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:54 AM
bzimport set Reference to bz71003.
matmarex created this task.Sep 18 2014, 3:12 PM

Is that needed for Grade C browsers? Maybe remove support for IE7 there also.

We only dropped JS for IE 6 and 7, we still support them for basic CSS.

Change 161932 had a related patch set uploaded by Bartosz Dziewoński:
CSSMin: Don't generate double rules for IE < 8 when embedding SVG files

https://gerrit.wikimedia.org/r/161932

Change 161932 merged by jenkins-bot:
CSSMin: Don't generate double rules for IE < 8 when embedding SVG files

https://gerrit.wikimedia.org/r/161932