when you load https://en.wikipedia.org/wiki/Special:MyPage/common.js in edit mode the page refactors, flashes and elements load very slowly causing the page to shift around quite a bit.
Version: unspecified
Severity: normal
Description
Description
Details
Details
- Reference
- bz71015
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| CodeEditor: Avoid movement while loading | mediawiki/extensions/CodeEditor | master | +41 -1 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Is this still a concern? For my personal experience right now (on a fast machine and connexion, to be fair) it's about as fast as our other editors – between the edit source link going active to the initial editor is ~0.8s, with the WikiEditor toolbar popping in ~0.1s later, the TemplateEditor hack adding to the toolbar after ~5ms, and then CodeEditor replacing the toolbar with its own after ~0.2s.
I'm sure it'd be cleaner to never show the WikiEditor toolbar at all, but I'm not sure what approach people favour. Tagging for wider visibility.
Comment Actions
Change 965854 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/CodeEditor@master] CodeEditor: Avoid vertical movement while loading
Comment Actions
Change 965854 merged by jenkins-bot:
[mediawiki/extensions/CodeEditor@master] CodeEditor: Avoid movement while loading
Comment Actions
The patch caused T351487: Gutter doesn't disappear after disabling code editor. I really doubt it was the right way. Not only there is the gutter, now the height of the textbox is inconsistent with pages where CodeEditor is not loaded because of padding-bottom: 22px;. It also doesn't have the intended effect when one of the subtoolbars (Advanced, Special characters, Help) is open (set by cookie wikiEditor-0-toolbar-section). Strikes me as a hack that brings more problems than it solves.