Page MenuHomePhabricator

Packed gallery with 2 arguments outputs invalid HTML
Closed, ResolvedPublic

Description

Copy the following into your wiki page:
<gallery mode="packed-overlay">
File:Image.png|link=Foo|Air Assault
</gallery>

You'll notice this generates the markup:
<ul class="gallery mw-gallery-packed-overlay">

		<li class="gallerybox" style="width: 122px">
      <div style="width: 122px">
  			<div class="thumb" style="width: 120px;">
          <div style="margin:0px auto;">
            <a href="/wiki/Foo">
              <img alt=""
                src="http://upload.wikimedia.org/wikipedia/commons/thumb/3/34/Image.png/180px-Image.png"
                width="120" height="120" data-file-width="500" data-file-height="500" />
            </a>
          </div>
        </div>
  			<div class="gallerytextwrapper" style="width: 100px">
          <div class="gallerytext">
            <p>Air Assault</p>
          </div>
        </div>
    </li>

</ul>

which has an unclosed DIV tag (the div <div style="width: 122px">)

this can cause problems with the Minerva skin, e.g. break rendering of footer (see bug 68228 for details)


Version: unspecified
Severity: normal

Details

Reference
bz71030

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:55 AM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz71030.
bzimport added a subscriber: Unknown Object (MLST).
  • Bug 68228 has been marked as a duplicate of this bug. ***

Well that's embarrassing...

gerritadmin wrote:

Change 161418 had a related patch set uploaded by Brian Wolff:
Add missing </div> tag to packed-overlay galleries

https://gerrit.wikimedia.org/r/161418

gerritadmin wrote:

Change 161418 merged by jenkins-bot:
Add missing </div> tag to packed-overlay galleries

https://gerrit.wikimedia.org/r/161418

thanks Brian! embarrassing indeed! :)