Page MenuHomePhabricator

QA: qunit test should have caught ext.flow.new error
Closed, ResolvedPublic

Description

Check out 0e560b8 (enwiki 1.24wmf21 as of 2014-09-12) and load a Topic, it exhibits Bug 71054 error in browser console. ResourceLoader knows something went wrong, mw.loader.getState( 'ext.flow.new' ) prints "error".

We should figure out why qunit tests didn't catch this and fix or add a test. qunit has a built-in test for failed RL modules https://git.wikimedia.org/blob/mediawiki%2Fcore.git/3daf61814db326f81c612186754f545c0548501e/tests%2Fqunit%2Fdata%2Ftestrunner.js#L442.

If I load by hand with mw.loader.getState('ext.module.new') there's no error, I guess there's some specific interaction on Topic: that a qunit test needs to mimic. (I'm also confused why https://test2.wikipedia.org/wiki/Special:JavaScriptTest/qunit doesn't run extension qunit tests.)

I'll file a separate bug to add

step "page has no ResourceLoader errors"

to Topic loading in tests/browser


Version: master
Severity: normal

Details

Reference
bz71070

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:58 AM
bzimport set Reference to bz71070.
Krinkle claimed this task.
Krinkle subscribed.

This has since been solved by a core structure test that asserts a non-error state on all loaded modules.