Page MenuHomePhabricator

mwoauth-form-description-* messages need refreshed parameters documentation
Open, LowPublic

Description

Some of these messages have the parameter $5, but from looking at the code in SpecialMWOAuth I am not even sure that it is properly passed.

Without proper parameter usage and documentation the messages will appear wrong and confusing to the users.


Version: unspecified
Severity: normal

Details

Reference
bz71092

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:43 AM
bzimport set Reference to bz71092.
bzimport added a subscriber: Unknown Object (MLST).
Amire80 created this task.Sep 20 2014, 5:59 PM

(This probably affects not only translation, but the English messages as well.)

Aklapper triaged this task as Low priority.Mar 17 2015, 10:56 AM
Aklapper added a project: Documentation.
Aklapper set Security to None.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 5 2015, 6:24 AM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMar 7 2017, 4:58 AM

Could this be a good Google-Code-in-2017 code in task?

@Amire80: Wondering if this task is still valid. And which exact actions are expected.

@Amire80 wrote:

Some of these messages have the parameter $5,

Looking at /i18n/en.json in OAuth extension, only one message has a $5 parameter noawadays:
"mwoauth-form-description-onewiki": "Hi $1,\n\nIn order to complete your request, '''$2''' needs permission to perform the following actions on your behalf on ''$4'':\n\n$5"
The actual code to concatenate the message key (via .=) is in frontend/specialpages/SpecialMWOAuth.php.
For $msgKey .= '-onewiki'; it does add another parameter to the $params[] array. (However there is no $3, ever.)
So I think the code is correct?

Without proper parameter usage and documentation

Which documentation do you refer to? The explanations in /i18n/qqq.json?