Page MenuHomePhabricator

Fix action=history for mw.ui
Closed, ResolvedPublic

Description

  • The input field needs to be inpul-lined
  • Fix alignment of <select>
  • Use mw-ui-constructive for "Go" button
  • Use mw-ui-neutral for "Compare selected revisions" button

Version: unspecified
Severity: normal

Details

Reference
bz71141

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz71141.
Prtksxna created this task.Sep 22 2014, 9:13 PM

(In reply to Prateek Saxena from comment #0)

  • Use mw-ui-constructive for "Go" button

Why is this mw-ui-constructive whereas bug 71141 ("Use mediawiki.ui elements on Special:Contributions") says, "search button should be progressive"?

They're both very similar in that they return a list of edits.

(In reply to Matthew Flasched from comment #1)

Why is this mw-ui-constructive whereas bug 71141
says, "search button should be progressive"?

I think you mean bug 71137. Yes, you are right it should be progressive. Sorry for the confusion.

gerritadmin wrote:

Change 162808 had a related patch set uploaded by Prtksxna:
HistoryAction: Use correct classes for buttons

https://gerrit.wikimedia.org/r/162808

gerritadmin wrote:

Change 162808 merged by jenkins-bot:
HistoryAction: Use correct classes for buttons

https://gerrit.wikimedia.org/r/162808