Page MenuHomePhabricator
Create Task
Maniphest T73214

VisualEditor: Pasting in image caption with a repeated reference causes VE to crash
Open, MediumPublicBUG REPORT
Actions

Description

I found this bug while trying to swap the captions of two images, but it can be duplicated with just one image:

  1. Paste this into a page and save:

Example text<ref name=Ref1>Ref 1</ref>
[[File:Example.jpg|thumb|Example text.<ref name=Ref1/>]]

  1. Launch VE
  2. Click the image and open the Media settings dialogue
  3. Select all the caption text (Ctrl-A) and cut it out (Ctrl-X)
  4. Apply changes
  5. Reopen the Media settings dialogue
  6. Paste the caption text back in (Ctrl-V)
  7. Apply changes

VE will now hang on the Media settings dialogue. The dialogue will not complete and will not cancel. It is completely impossible to carry on editing, all the changes up to that point have to be discarded.

I am using FF32, Windows 7, Monobooks

Version: unspecified
Severity: major

Details

Reference
bz71214

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:51 AM
• bzimport added projects: VE-deploy-nextup, VisualEditor-DataModel.
• bzimport set Reference to bz71214.
Spinningspark created this task.Sep 24 2014, 1:09 AM
Krenair added a comment.Nov 1 2014, 11:08 PM

See also bug 60919?

Jdforrester-WMF added a project: VisualEditor.Nov 23 2014, 10:48 PM
Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Nov 23 2014, 10:59 PM
Jdforrester-WMF removed a project: VE-deploy-nextup.Nov 24 2014, 10:02 PM
Jdforrester-WMF moved this task from External and Administrivia to Freezer on the VisualEditor board.Jan 15 2015, 12:10 AM
Jdforrester-WMF removed Catrope as the assignee of this task.Apr 17 2015, 5:54 PM
matmarex added a subtask: T49344: Internal nodes should eventually be in a separate document ("sub-documents").Mar 13 2018, 6:55 PM
Aklapper changed the status of subtask T49344: Internal nodes should eventually be in a separate document ("sub-documents") from Stalled to Open.Nov 3 2020, 11:25 AM
Aklapper changed the subtype of this task from "Task" to "Bug Report".Feb 15 2022, 9:39 PM
matmarex subscribed.Aug 20 2023, 8:59 PM

VE will now hang on the Media settings dialogue. The dialogue will not complete and will not cancel. It is completely impossible to carry on editing, all the changes up to that point have to be discarded.

It seems like it no longer hangs this way now, although the steps still result in an exception ("TypeError: group.firstNodes[index2] is undefined" – same one as T259038) and mess up some internal state, which causes further exceptions whenever you do basically anything (although I'm not sure what's the impact on the users, I was still able to make changes and save the page despite them).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL