Page MenuHomePhabricator

Don't use background-image-svg when there is no SVG
Closed, DeclinedPublic

Description

See https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGettingStarted.git/5f5c2f1c9522765d631f9f9fc05ca21a76ae3486/resources%2Flightbulb%2Flightbulb.flyout.less#L212

	.background-image-svg('images/ajax-loader-2x.gif', 'images/ajax-loader.gif');

It looks like the idea is to use the higher-resolution GIF on browsers that support SVG. However, there's no absolute correlation between screen pixel density and browser support for SVG backgrounds.

Alternatives are:

  • <img srcset> (which requires converting it to an <img>). There is also a module jQuery.hidpi, which can be used to polyfill this.

Version: master
Severity: normal

Details

Reference
bz71253

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:53 AM
bzimport set Reference to bz71253.
bzimport added a subscriber: Unknown Object (MLST).
Aklapper edited subscribers, added: Aklapper; removed: rmoen, Mattflaschen-WMF.

MediaWiki-extensions-GettingStarted has been removed from Wikimedia wikis and is getting archived per T292654. Thus declining this task to reflect reality.

See e.g. GrowthExperiments-NewcomerTasks or #GuidedTour instead nowadays for related use cases.