Page MenuHomePhabricator

Download link should save to a sensible filename with extension etc.
Closed, ResolvedPublic

Description

A download URL like this is offered by the interface, which (at least in Firefox 32) saves to a a file like
$ file 3de5e15c0acbde1deccff87bb7a3a90197b42135
3de5e15c0acbde1deccff87bb7a3a90197b42135: PDF document, version 1.5

Wonderful, but better would be "3de5e15c0acbde1deccff87bb7a3a90197b42135.pdf" or "Diffuser.pdf" (do we have a function in core to produce Windows-proof filenames?). This is for OCG/rdf2latex but probably any other rendering as well.


Version: unspecified
Severity: normal
URL: https://en.wikipedia.org/w/index.php?title=Special:Book&bookcmd=download&collection_id=3de5e15c0acbde1deccff87bb7a3a90197b42135&writer=rdf2latex&return_to=Diffuser+%28sewage%29
See Also:
http://web.archive.org/web/20110600000000/http://code.pediapress.com/wiki/ticket/749

Details

Reference
bz71286

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:56 AM
bzimport added a project: Collection.
bzimport set Reference to bz71286.

#749 "Better default names for files" was probably related.

Partially fixed by https://gerrit.wikimedia.org/r/164613 (which adds the missing extension). We could do better about using the article title for the filename, though, and my reading of the RFC for contents disposition indicates that we might have an issue here with filename characters outside iso8859-1 as well.

Change 165213 had a related patch set uploaded by Cscott:
Use article title as download filename.

https://gerrit.wikimedia.org/r/165213

Change 165213 merged by jenkins-bot:
Use article title as download filename.

https://gerrit.wikimedia.org/r/165213