Page MenuHomePhabricator

Echo pings are not recognized if the signature uses custom namespace alias (defined per-wiki, rather than for the language)
Closed, ResolvedPublic

Description

Apparently Echo pings are not recognized if the signature uses custom namespace alias (defined per-wiki, rather than for the language).

Support for localised namespaces was implemented per bug 53132, but custom aliases don't work.


Version: master
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132
https://bugzilla.wikimedia.org/show_bug.cgi?id=73366

Details

Reference
bz71353

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:43 AM
bzimport added a project: Notifications.
bzimport set Reference to bz71353.

gerritadmin wrote:

Change 163152 had a related patch set uploaded by Bartosz Dziewoński:
DiscussionParser: Support custom namespace aliases in signatures

https://gerrit.wikimedia.org/r/163152

gerritadmin wrote:

Change 163152 abandoned by Bartosz Dziewoński:
DiscussionParser: Support custom namespace aliases in signatures

Reason:
Okay.

https://gerrit.wikimedia.org/r/163152

Patch abandoned, resetting to New. :(

also did not work when using an alias not in the signature

correctly: [[user:A]] text ~~~~ ->[[user:X]] text [[urer:B]]
my variant: [[u:A]] text ~~~~ -> [[u:X]] text [[urer:B]]

  • Bug 70236 has been marked as a duplicate of this bug. ***

The patch can be restored if anyone appeases code reviewers, it works perfectly. But I am not going to rewrite half of Echo to make everyone happy.

gerritadmin wrote:

Change 163327 had a related patch set uploaded by EBernhardson:
Make signatures within parser output findable

https://gerrit.wikimedia.org/r/163327

gerritadmin wrote:

Change 163651 had a related patch set uploaded by EBernhardson:
Detect signature using Title class

https://gerrit.wikimedia.org/r/163651

gerritadmin wrote:

Change 163327 abandoned by EBernhardson:
Make signatures within parser output findable

Reason:
move forward with the earlier patch that does same thing

https://gerrit.wikimedia.org/r/163327

(In reply to Sunpriat from comment #4)

also did not work when using an alias not in the signature
correctly: [[user:A]] text ~~~~ ->[[user:X]] text [[urer:B]]
<s>my variant: [[u:A]] text ~~~~ -> [[u:X]] text [[urer:B]]</s>

[[У:A]] text ~~~~ -> [[У:X]] text [[У:B]]
but not, then was also an alias in the signature. Alias in ruWP by default in the signature...

gerritadmin wrote:

Change 163651 merged by jenkins-bot:
Detect signature using Title class

https://gerrit.wikimedia.org/r/163651

The fix has been merged and should be deployed within two weeks.

And we are back... =/

Sunpriat removed a subscriber: Sunpriat.Dec 28 2014, 6:04 PM