Page MenuHomePhabricator
Create Task
Maniphest T73537

wgGuidedTourHelpGuiderUrl should not be in HTML source of every page
Closed, ResolvedPublic
Actions

Description

wgGuidedTourHelpGuiderUrl is using MakeGlobalVariablesScript instead of ResourceLoaderGetConfigVars unnecessarily. This causes it to be embedded into the source, instead of the startup module.

Version: master
Severity: normal

Details

Reference
bz71537

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:55 AM
• bzimport added a project: MediaWiki-extensions-GuidedTour.
• bzimport set Reference to bz71537.
• bzimport added a subscriber: Unknown Object (MLST).
• Mattflaschen-WMF created this task.Oct 1 2014, 10:42 PM
• bzimport added a comment.Oct 1 2014, 10:48 PM

gerritadmin wrote:

Change 164252 had a related patch set uploaded by Mattflaschen:
Move wgGuidedTourHelpGuiderUrl to static config data

https://gerrit.wikimedia.org/r/164252

• bzimport added a comment.Oct 2 2014, 9:06 AM

gerritadmin wrote:

Change 164252 merged by jenkins-bot:
Move wgGuidedTourHelpGuiderUrl to static config data

https://gerrit.wikimedia.org/r/164252

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL