Page MenuHomePhabricator

problems with footer formatting in WikiGrok dialog B
Closed, ResolvedPublic

Description

screenshot of unwrapped footer

Two problems:

  1. When the footer text doesn't wrap, the footer button is taller than the footer and overhangs it.
  2. When the footer text does wrap, it becomes indented (due to a margin being applied to a span) and the footer becomes taller than the button.

Ideally the footer and button should always be the same height (subject to design input).

See screenshots.


Version: unspecified
Severity: normal

Attached:

unwrapped.png (83×392 px, 9 KB)

Details

Reference
bz71577

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:58 AM
bzimport set Reference to bz71577.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 16652
screenshot of wrapped footer

Attached:

wrapped.png (105×318 px, 9 KB)

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/mzgbFQK2

Change 164500 had a related patch set uploaded by Jdlrobson:
Wikigrok B improvements

https://gerrit.wikimedia.org/r/164500

Change 164500 merged by jenkins-bot:
Wikigrok B improvements

https://gerrit.wikimedia.org/r/164500

Change 165386 had a related patch set uploaded by Jdlrobson:
MediaWiki UI: Use em's for the button width

https://gerrit.wikimedia.org/r/165386

Change 165386 merged by jenkins-bot:
MediaWiki UI: Use em's for the button width

https://gerrit.wikimedia.org/r/165386