Page MenuHomePhabricator async output messages jumbled with user interaction on main thread
Closed, ResolvedPublic


when running with manual confirming of each replace, bot have often some pages in save queue. In compat all messages about saving appeared after confirming some of next

>>>Page 1<<<
Do you fant to accept... [y/n]y
Page [[Lorem]] saved
Page [[Ipsum]]saved

In core these messages sometimes appears before confirming 

No changes were necessary in [[Ivan Král vydá po dvanácti letech nové album]]
Page [[Izrael popřel, že by střílel na vozidlo OSN]] saved

>>> Je zvažováno obnovení meziměstské tramvaje mezi Bratislavou a Vídní <<<
-  | odkaz na periodikum = IDnes
+  | odkaz na periodikum =

Do you want to accept these changes? ([y]es, [N]o, [e]dit, open in [b]rowser, [a
]ll, [q]uit) Page [[Italka odpojená po letech od vyživovacích přístrojů zemřela]
] saved

Version: core-(2.0)
Severity: normal

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:45 AM
bzimport set Reference to bz71646.
bzimport added a subscriber: Unknown Object (????).
jayvdb changed the task status from Open to Stalled.Jun 9 2015, 5:57 AM
jayvdb triaged this task as Medium priority.
jayvdb updated the task description. (Show Details)
jayvdb edited projects, added; removed Pywikibot-Scripts.
jayvdb set Security to None.

Change 248680 had a related patch set uploaded (by Mpaa):
Control output message when saving in async mode

Mpaa changed the task status from Stalled to Open.Oct 25 2015, 10:14 AM

Change 248680 merged by jenkins-bot:
Control output message when saving.

jayvdb assigned this task to Mpaa.
Xqt subscribed.

Reopened. I think the current implementation is not very usefull because that problem not only occurs on and subclasses of that bot but all scripts putting asynchroneous have this problem. This is core-specific and does not occur in compat because there is a cache_output implemented when any input aquires input_lock. Refer # User output/logging functions in

Change 282818 had a related patch set uploaded (by Xqt):
[bugfix] Port cache_output from compat

Xqt raised the priority of this task from Medium to High.May 28 2017, 11:55 AM
Dvorapa lowered the priority of this task from High to Low.May 31 2018, 7:19 PM
Mpaa removed Mpaa as the assignee of this task.Oct 27 2020, 6:05 PM
Xqt claimed this task.

Change 282818 merged by jenkins-bot:

[pywikibot/core@master] [bugfix] Port cache_output from compat

Change 729234 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [IMPR] Re-enable cached output functionality from compat

Change 729234 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] Re-enable cached output functionality from compat