Page MenuHomePhabricator

Update usage instructions for mw-ui-destructive
Closed, ResolvedPublic

Description

Special:Block uses the destructive button

The current documentation says "Use destructive buttons for actions which result in the destruction of data. e.g. deleting a page. This should not be used for cancel buttons."

No data is destroyed by blocking so this message will need to be updated to include actions which result in what could be considered negative actions.


Version: unspecified
Severity: normal

Details

Reference
bz71856

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:58 AM
bzimport set Reference to bz71856.
MC8 added a comment.Oct 12 2014, 7:04 PM

I searched MediaWiki core's ./includes directory for "destructive", and found the following places where we currently use a red destructive button:

  • Blocking a user
  • Resetting one's preferences to the site defaults
  • Removing items from one's watchlist

Do we anticipate marking any other actions destructive?

MC8 added a comment.Oct 12 2014, 7:59 PM

(In reply to Douglas Gardner from comment #1)

I searched MediaWiki core's ./includes directory for "destructive", and
found the following places where we currently use a red destructive button:

  • Blocking a user
  • Resetting one's preferences to the site defaults
  • Removing items from one's watchlist

Do we anticipate marking any other actions destructive?

There's also, of course, deleting a page.

I'm sure there might be other places that need destructive buttons, If delete page is not destructive, it should be, can you log a bug? Eventually that will likely be "move back to Drafts" which will be constructive action. But we're not there yet.

(In reply to Jared in comment #3)

If delete page is not destructive, it should be, can you log a bug?

With the Beta Feature turned on the delete page uses destructive.

gerritadmin wrote:

Change 168254 had a related patch set uploaded by Mattflaschen:
Tweak 'destructive' use case in style guide

https://gerrit.wikimedia.org/r/168254

gerritadmin wrote:

Change 168254 merged by jenkins-bot:
Tweak 'destructive' use case in style guide

https://gerrit.wikimedia.org/r/168254