Page MenuHomePhabricator

Simplified/Traditional Chinese not found when "Chinese" entered
Closed, ResolvedPublic


When I search on for "Chinese" under languages to translate to I only get the disabled options but not Simplified Chinese (zh-hans) or Traditional Chinese (zh-hant).
Wouldn't it be better to have those show up instead when I search for just "Chinese"?

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:43 AM
bzimport set Reference to bz71891.
bzimport added a subscriber: Unknown Object (MLST).

This issue is still present, and the cause is that we only do prefix search. Injecting additional names such as Chinese (traditional) could work around the issue, if we cannot change from prefix search to word search due to performance concerns.

NOTE: Texts in this comment are already tracked at T52270

To be honesty, I can confirm on zhwiki that:

By using zh, zh-hans, zh-hant, zh-mo, and zh-my (suddenly want to say, why we can't drop it?), only zh-cn, zh-tw, zh-sg, and zh-hk shown:

1.png (695×1 px, 61 KB)

When using one of these four, the one that you chose will be hidden (should be expected):

2.png (693×1 px, 62 KB)

You can also just confirm it on any of WMF wikis, the results are per above.

On TWN, however, other than these four variants, I can also see Min Nan (Why? Why? Why?):

1.png (484×1 px, 57 KB)

As per above, there's nothing to do under zh.* projects, hence removing that tag.

@Shizhao feel free to re-add it if there's something that T52270 not included.

Change 386158 had a related patch set uploaded (by Amire80; owner: Amire80):
[mediawiki/extensions/UniversalLanguageSelector@master] Add special language names to facilitate searching

Change 386158 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Add special language names to facilitate searching

The example still doesn't work.

The issue is that we have this much improved backend search but the frontend does not call the backend if it finds results locally. We should change that.

Change 393589 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/UniversalLanguageSelector@master] Improve ULS language search api

Change 393589 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Improve ULS language search api

@Nikerabbit - the patch was merged to master - does it mean that it's in translatewiki?

It seems that the issue is still present n translatewiki: entering the search term 'Chinese' will return the following:

Screen Shot 2017-12-01 at 4.40.10 PM.png (467×1 px, 152 KB)

The choices will lead to a page with the

Translations to this language in this group have been disabled. Reason:

This language code should remain unused. Localise in zh-hans or zh-hant please.

Entering zh-hans will correctly display

Screen Shot 2017-12-01 at 4.27.38 PM.png (474×1 px, 80 KB)

Note: In cx-testing, zh-hans and zh-hant are not recognized on ContentTranslation page. The ULS finds both. was not updated. I updated it now.

Checked in - both 中文(简体)(Simplified Chinese)
中文(繁體)(Traditional Chinese) are shown when 'Chinese' search term is entered.