Add a hook for custom diff engines (for Extension:WikEdDiff)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Cacycle
	Oct 10 2014, 3:20 PM

Description

I have written a new extension for custom inline-diff with block move support(WikEdDiff, https://www.mediawiki.org/wiki/Extension:WikEdDiff). This extension needs a new hook.

E.g. "CustomDifferenceEngine" in /includes/diff/DifferenceEngine.php in function generateTextDiffBody after "$ntext = str_replace( "\r\n", "\n", $ntext );":

Custom difference engine hook

wfRunHooks( 'CustomDifferenceEngine', array( &$otext, &$ntext, &$diffText ) );
if ( $diffText !== false ) {

		wfProfileOut( __METHOD__ );
		return $diffText;

}

I am new to git/Gerrit and wanted to discuss this here first.

Version: unspecified
Severity: enhancement

Details

Reference: bz71916

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 3:45 AM

• bzimport added a project: MediaWiki-Page-diffs.

• bzimport set Reference to bz71916.

Cacycle created this task.Oct 10 2014, 3:20 PM

Thanks for taking the time to report this!

In case you don't get feedback here I'd recommend to just put an initial patch into Gerrit, to iterate on. See http://www.mediawiki.org/wiki/Gerrit/Tutorial and https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker

OK, I have committed this, please see https://gerrit.wikimedia.org/r/#/c/166143/

Thank you!

gerritadmin wrote:

Change 166143 had a related patch set uploaded by Martineznovo:
Add a hook for custom diff engines (WikEdDiff)

https://gerrit.wikimedia.org/r/166143

I've just updated the commit message so it's properly linked to the bug

gerritadmin wrote:

Change 169677 had a related patch set uploaded by Cacycle:
Add a hook for custom diff engines (WikEdDiff)

https://gerrit.wikimedia.org/r/169677

gerritadmin wrote:

Change 166143 had a related patch set uploaded by PleaseStand:
Add a hook for custom diff engines (WikEdDiff)

https://gerrit.wikimedia.org/r/166143

gerritadmin wrote:

Change 169677 abandoned by PleaseStand:
Add a hook for custom diff engines (WikEdDiff)

Reason:
Squashed into Change-Id: I9da63c1ceb339bfeba7beddc712be51977b95f65

https://gerrit.wikimedia.org/r/169677

gerritadmin wrote:

Change 170716 had a related patch set uploaded by Cacycle:
Add a hook for custom difference engine (WikEdDiff)

https://gerrit.wikimedia.org/r/170716

gerritadmin wrote:

Change 170716 abandoned by Cacycle:
Add a hook for custom difference engine (WikEdDiff)

Reason:
Should have gone into https://gerrit.wikimedia.org/r/#/c/166143/

https://gerrit.wikimedia.org/r/170716

gerritadmin wrote:

Change 170723 had a related patch set uploaded by Cacycle:
Add a hook for custom difference engine (WikEdDiff)

https://gerrit.wikimedia.org/r/170723

gerritadmin wrote:

Change 170723 abandoned by Cacycle:
Add a hook for custom difference engine (WikEdDiff)

Reason:
Should have gone into https://gerrit.wikimedia.org/r/#/c/166143/

https://gerrit.wikimedia.org/r/170723

Nemo_bis awarded a token.Dec 12 2014, 8:19 AM

TheDJ closed this task as Resolved.Dec 21 2015, 11:07 AM

TheDJ removed a project: Patch-For-Review.

TheDJ set Security to None.

Seems we forgot to close this one. Was added in the 1.25 release. Hook was documented in hooks.txt and on mw.org. Nothing else left to do.

@Jdlrobson See here, for hooks for custom diff engines

Aklapper added a project: MediaWiki-Page-history.Sep 20 2019, 7:48 PM

Add a hook for custom diff engines (for Extension:WikEdDiff)Closed, ResolvedPublicActions

Description

Details

Event Timeline

Add a hook for custom diff engines (for Extension:WikEdDiff)
Closed, ResolvedPublic
Actions