Page MenuHomePhabricator

rename fallback-svg to fallback-image
Closed, ResolvedPublic


Author: physik

since it's now decided on client side if it's an svg or an png image
svg might be confusing if it's replaced by png

Version: unspecified
Severity: normal



Related Objects


Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:47 AM
bzimport added a project: Math.
bzimport set Reference to bz71955.
bzimport added a subscriber: Unknown Object (MLST).

That's what I initially try in patch 1 of, but I realized that PNG and SVG have slightly different style (for vertical alignment in inline mode and horizontal centering in display mode) so I was not 100% sure we could merge them.

As discussed on IRC, after the only difference will be in the vertical alignment which is done in MathMathML.php for the SVG.

For the PNG, we could add "vertical-align: center" in MathTexvc.php and in ext.math.js. Then the class name could be merged.

gerritadmin wrote:

Change 166280 had a related patch set uploaded by Frédéric Wang:
Rename fallback-svg and fallback-png to fallback-image

gerritadmin wrote:

Change 166280 merged by Physikerwelt:
Rename fallback-svg and fallback-png to fallback-image