Author: physik
Description:
since it's now decided on client side if it's an svg or an png image
svg might be confusing if it's replaced by png
Version: unspecified
Severity: normal
Author: physik
Description:
since it's now decided on client side if it's an svg or an png image
svg might be confusing if it's replaced by png
Version: unspecified
Severity: normal
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | None | T67341 Release Math 2.0 | |||
Resolved | None | T73955 rename fallback-svg to fallback-image |
That's what I initially try in patch 1 of https://gerrit.wikimedia.org/r/#/c/166084/, but I realized that PNG and SVG have slightly different style (for vertical alignment in inline mode and horizontal centering in display mode) so I was not 100% sure we could merge them.
As discussed on IRC, after https://gerrit.wikimedia.org/r/#/c/166212/ the only difference will be in the vertical alignment which is done in MathMathML.php for the SVG.
For the PNG, we could add "vertical-align: center" in MathTexvc.php and in ext.math.js. Then the class name could be merged.
gerritadmin wrote:
Change 166280 had a related patch set uploaded by Frédéric Wang:
Rename fallback-svg and fallback-png to fallback-image
gerritadmin wrote:
Change 166280 merged by Physikerwelt:
Rename fallback-svg and fallback-png to fallback-image