VisualEditor Mobile: [Regression wmf3] The fields inside Citations dialog are appearing at a fixed rather than whole-screen width in mobile VE
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ryasmeen
	Oct 16 2014, 12:39 AM

Description

Screenshot

Steps to reproduce:

1.Open a page with mobile VE
2.Open any citation dialog like Cite>Website/book

Observed Result:
The fields inside Citations dialog are appearing at a much smaller size

See the screenshot attached

Version: unspecified
Severity: normal

Attached:

• bzimport raised the priority of this task from to Low.Nov 22 2014, 3:57 AM

• bzimport set Reference to bz72112.

This is almost certainly because of the MediaWiki theme; maybe that now actually sets fields' default width, and the previous theme wasn't?

gerritadmin wrote:

Change 169968 had a related patch set uploaded by Jforrester:
Set input/menu widgets to have a max-width expanding to 100% rather than hard-coded

gerritadmin wrote:

Change 169968 merged by jenkins-bot:
Set input/menu widgets to have a max-width expanding to 100% rather than hard-coded

confirmed in betalabs.

Previously it was:
oo-ui-textInputWidget {
.  width: 20em;
}

After the fix:
.oo-ui-textInputWidget {

.  width: 100%;
.  max-width: 50em;

}

Created attachment 16986
Screenshot

Its still not taking full width .Reopening it.

Attached:

It's not meant to. This is wide enough for tablets and phones.

Created attachment 16987
Screenshot

Is it okay if the width appears this way in tablet?

Attached:

Verified the fix in production

	F15294: Screen_Shot_2014-10-31_at_2.55.04_PM.png
	Nov 22 2014, 3:57 AM