We should be able to switch to rc_source now that the schema change is complete and populated. Mostly this means changing queries in core and throughout mediawiki to use the rc_source column instead of rc_type when querying the recentchanges table and marking the appropriate things deprecated.
Description
Details
- Reference
- bz72157
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T90435 [Epic] Wikidata watchlist improvements (client) | |||
| Open | None | T400696 FY25-26 WE1.4.1 RecentChanges database performance improvements | |||
| Resolved | Zabe | T74157 [Story] Use rc_source and drop rc_type | |||
| Resolved | aude | T44289 [Task] Use rc_source for filtering Wikibase recent changes and watchlist entries in the client | |||
| Resolved | Zabe | T401912 Duplicate rc_name_type_patrolled_timestamp index on rc_source | |||
| Resolved | Ladsgroup | T402010 Add new rc_name_source_patrolled_timestamp index to recentchanges table in wmf production | |||
| Resolved | • Marostegui | T410531 Drop rc_type from recentchanges in wmf production |
Event Timeline
Change #1179290 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/Flow@master] Stop falling back to rc_type
Change #1179288 merged by jenkins-bot:
[mediawiki/core@master] RecentChange: Drop obsolete SRC_EXTERNAL constant
Change #1179287 merged by jenkins-bot:
[mediawiki/core@master] Replace usages of rc_type with rc_source
Change #1179290 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Stop falling back to rc_type
Change #1179705 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/PageTriage@master] Replace usage of rc_type with rc_source
Change #1179716 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/skins/Cosmos@master] Replace usage of rc_type with rc_source
Change #1179717 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/skins/Mirage@master] Replace usage of rc_type with rc_source
Change #1179721 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/core@master] RecentChange: Provide a list of internal source
Change #1179705 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Replace usage of rc_type with rc_source
Change #1179716 merged by Universal Omega:
[mediawiki/skins/Cosmos@master] Replace usage of rc_type with rc_source
Change #1179721 merged by jenkins-bot:
[mediawiki/core@master] RecentChange: Provide a list of internal source
Change #1179717 merged by jenkins-bot:
[mediawiki/skins/Mirage@master] Replace usage of rc_type with rc_source
Change #1180133 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/CheckUser@master] Replace usages of rc_type with rc_source
Change #1180975 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/core@master] Replace usages of rc_type with rc_source
Change #1181177 had a related patch set uploaded (by Adarsh2406; author: Adarsh2406):
[mediawiki/core@master] T74157: Use rc_source and drop rc_type - Depricated rc_type to rc_source !
Change #1181177 had a related patch set uploaded (by Pppery; author: Adarsh2406):
[mediawiki/core@master] Use rc_source and drop rc_type
Should we document this first in https://www.mediawiki.org/wiki/Manual:Recentchanges_table ?
rc_source is there already described as "The source of the change entry (replaces rc_type).", but it could certainly be made more clear.
The removal of rc_type should indeed be documented, just like other removed columns (e.g. rc_moved_to_ns), and the new DESCRIBE and SHOW INDEX outputs should be added. However, this shouldn’t happen before the columns are actually removed (“actual removal” may mean either that the change is merged or that the DROP COLUMN queries are run in production).
Change #1178899 merged by Ladsgroup:
[operations/puppet@production] maintain-views: Stop providing rc_new and rc_type to replicas
Change #1183283 had a related patch set uploaded (by Tim Starling; author: Tim Starling):
[mediawiki/core@master] recentchanges: Allow registration of known rc_source values
Change #1184959 had a related patch set uploaded (by Tim Starling; author: Tim Starling):
[mediawiki/core@master] recentchanges: Use the new extension attribute for active user queries
Change #1183283 merged by jenkins-bot:
[mediawiki/core@master] recentchanges: Allow registration of known rc_source values
Change #1184959 merged by jenkins-bot:
[mediawiki/core@master] recentchanges: Use the new extension attribute for active user queries
Change #1187802 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/ORES@master] Replace most usages of rc_type with rc_source
Change #1187807 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/ORES@master] Allow filtering models by rc_source instead of rc_type
Change #1180975 merged by jenkins-bot:
[mediawiki/core@master] Replace some usages of rc_type with rc_source
Change #1180133 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Replace usages of rc_type with rc_source
Change #1190323 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/Translate@master] Replace usages of rc_type with rc_source
Change #1190323 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Replace usages of rc_type with rc_source
Change #1191744 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/Echo@master] Replace usage of rc_type with rc_source
Change #1191748 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/FlaggedRevs@master] Replace usage of rc_type with rc_source
Change #1191753 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/core@master] ChangesListSpecialPage: Use rc_source instead of rc_type
Change #1191754 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/core@master] Deprecate SpecialWatchlistGetNonRevisionTypes Hook
Change #1191803 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/core@master] RecentChangeLookup: Introduce method to check if rc has primary source
Change #1191754 merged by jenkins-bot:
[mediawiki/core@master] Deprecate SpecialWatchlistGetNonRevisionTypes Hook
Change #1191753 abandoned by Zabe:
[mediawiki/core@master] ChangesListSpecialPage: Use rc_source instead of rc_type
Reason:
Code to be dropped in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1191646
Change #1187807 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Allow filtering models by rc_source instead of rc_type
Change #1187802 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Replace most usages of rc_type with rc_source
Change #1191744 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Email notifications: Replace rc_type with rc_source, ignore Flow edits
Change #1191803 merged by jenkins-bot:
[mediawiki/core@master] RecentChangeLookup: Introduce method to check if rc has primary source
Change #1191748 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Replace usages of rc_type with rc_source
Change #1197028 had a related patch set uploaded (by Zabe; author: Zabe):
[operations/mediawiki-config@master] Use rc_source instead of rc_type in ORES config
Change #1197028 merged by jenkins-bot:
[operations/mediawiki-config@master] Use rc_source instead of rc_type in ORES config
Mentioned in SAL (#wikimedia-operations) [2025-10-21T23:47:14Z] <zabe@deploy2002> Started scap sync-world: Backport for [[gerrit:1197028|Use rc_source instead of rc_type in ORES config (T74157)]]
Mentioned in SAL (#wikimedia-operations) [2025-10-21T23:52:01Z] <zabe@deploy2002> zabe: Backport for [[gerrit:1197028|Use rc_source instead of rc_type in ORES config (T74157)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.
Mentioned in SAL (#wikimedia-operations) [2025-10-21T23:56:31Z] <zabe@deploy2002> Finished scap sync-world: Backport for [[gerrit:1197028|Use rc_source instead of rc_type in ORES config (T74157)]] (duration: 09m 16s)
Change #1199087 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/ORES@master] Emit deprecation warnings when a model is configured with types
Change #1199087 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Emit deprecation warnings when a model is configured with types
Change #1200089 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/core@master] Drop SpecialWatchlistGetNonRevisionTypesHook
Change #1181177 abandoned by Adarsh2406:
[mediawiki/core@master] Use rc_source and drop rc_type
Change #1200089 merged by jenkins-bot:
[mediawiki/core@master] Drop SpecialWatchlistGetNonRevisionTypesHook
Change #1203250 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/core@master] Remove remaining usages of rc_type
Change #1203250 merged by jenkins-bot:
[mediawiki/core@master] Stop reading from the rc_type field
Change #1205974 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/ORES@master] Drop support for filtering model for rc_type
Change #1205977 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/Flow@master] Stop writing to rc_type
Change #1205978 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/Wikistories@master] Stop writing to rc_type
Change #1205979 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/WikiLambda@master] Stop writing to rc_type
Change #1205980 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/Wikibase@master] Stop writing to rc_type
Change #1205981 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/core@master] Stop writing to rc_type
Change #1205982 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/core@master] Deprecate RecentChange::parse(From|To)RCType
Change #1205974 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Drop support for filtering model by rc_type
Change #1205979 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] Stop writing to rc_type
Change #1205978 merged by jenkins-bot:
[mediawiki/extensions/Wikistories@master] Stop writing to rc_type
Change #1205977 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Stop writing to rc_type
Change #1205982 merged by jenkins-bot:
[mediawiki/core@master] Deprecate RecentChange::parse(From|To)RCType
Change #1206436 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/core@master] Drop rc_type from recentchanges
Change #1205980 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Stop writing to rc_type
Change #1205981 merged by jenkins-bot:
[mediawiki/core@master] Stop writing to rc_type
Change #1206436 merged by jenkins-bot:
[mediawiki/core@master] Drop rc_type from recentchanges