Page MenuHomePhabricator

[Story] Use rc_source and drop rc_type
Closed, ResolvedPublic

Description

We should be able to switch to rc_source now that the schema change is complete and populated. Mostly this means changing queries in core and throughout mediawiki to use the rc_source column instead of rc_type when querying the recentchanges table and marking the appropriate things deprecated.

Details

Reference
bz72157
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
mediawiki/coremaster+728 -40
mediawiki/coremaster+1 -9
mediawiki/extensions/Wikibasemaster+0 -16
mediawiki/extensions/Flowmaster+4 -4
mediawiki/extensions/Wikistoriesmaster+1 -2
mediawiki/extensions/WikiLambdamaster+0 -2
mediawiki/coremaster+18 -34
mediawiki/extensions/ORESmaster+6 -13
mediawiki/coremaster+7 -25
mediawiki/coremaster+3 -38
mediawiki/coremaster+282 -132
mediawiki/extensions/ORESmaster+5 -0
operations/mediawiki-configmaster+8 -8
mediawiki/extensions/FlaggedRevsmaster+24 -18
mediawiki/coremaster+12 -0
mediawiki/extensions/Echomaster+3 -2
mediawiki/extensions/ORESmaster+36 -22
mediawiki/extensions/ORESmaster+37 -26
mediawiki/coremaster+6 -1
mediawiki/coremaster+8 -8
mediawiki/extensions/Translatemaster+6 -3
mediawiki/extensions/CheckUsermaster+73 -30
mediawiki/coremaster+59 -36
mediawiki/coremaster+89 -20
mediawiki/coremaster+17 -0
mediawiki/coremaster+26 -0
operations/puppetproduction+6 -6
mediawiki/skins/Miragemaster+1 -1
mediawiki/skins/Cosmosmaster+1 -1
mediawiki/extensions/PageTriagemaster+1 -1
mediawiki/coremaster+97 -76
mediawiki/extensions/Flowmaster+3 -17
mediawiki/coremaster+2 -1
mediawiki/extensions/AbuseFiltermaster+8 -8
mediawiki/extensions/Wikibasemaster+1 -1
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change #1179290 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Flow@master] Stop falling back to rc_type

https://gerrit.wikimedia.org/r/1179290

Change #1179288 merged by jenkins-bot:

[mediawiki/core@master] RecentChange: Drop obsolete SRC_EXTERNAL constant

https://gerrit.wikimedia.org/r/1179288

Change #1179287 merged by jenkins-bot:

[mediawiki/core@master] Replace usages of rc_type with rc_source

https://gerrit.wikimedia.org/r/1179287

Change #1179290 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Stop falling back to rc_type

https://gerrit.wikimedia.org/r/1179290

Change #1179705 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/PageTriage@master] Replace usage of rc_type with rc_source

https://gerrit.wikimedia.org/r/1179705

Change #1179716 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/skins/Cosmos@master] Replace usage of rc_type with rc_source

https://gerrit.wikimedia.org/r/1179716

Change #1179717 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/skins/Mirage@master] Replace usage of rc_type with rc_source

https://gerrit.wikimedia.org/r/1179717

Change #1179721 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] RecentChange: Provide a list of internal source

https://gerrit.wikimedia.org/r/1179721

Tacsipacsi renamed this task from [Story] Use rc_source and drop RC_TYPE to [Story] Use rc_source and drop rc_type.Aug 18 2025, 4:23 PM
Tacsipacsi subscribed.

Change #1179705 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Replace usage of rc_type with rc_source

https://gerrit.wikimedia.org/r/1179705

Change #1179716 merged by Universal Omega:

[mediawiki/skins/Cosmos@master] Replace usage of rc_type with rc_source

https://gerrit.wikimedia.org/r/1179716

Change #1179721 merged by jenkins-bot:

[mediawiki/core@master] RecentChange: Provide a list of internal source

https://gerrit.wikimedia.org/r/1179721

Change #1179717 merged by jenkins-bot:

[mediawiki/skins/Mirage@master] Replace usage of rc_type with rc_source

https://gerrit.wikimedia.org/r/1179717

Change #1180133 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CheckUser@master] Replace usages of rc_type with rc_source

https://gerrit.wikimedia.org/r/1180133

Change #1180975 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Replace usages of rc_type with rc_source

https://gerrit.wikimedia.org/r/1180975

Change #1181177 had a related patch set uploaded (by Adarsh2406; author: Adarsh2406):

[mediawiki/core@master] T74157: Use rc_source and drop rc_type - Depricated rc_type to rc_source !

https://gerrit.wikimedia.org/r/1181177

Change #1181177 had a related patch set uploaded (by Pppery; author: Adarsh2406):

[mediawiki/core@master] Use rc_source and drop rc_type

https://gerrit.wikimedia.org/r/1181177

rc_source is there already described as "The source of the change entry (replaces rc_type).", but it could certainly be made more clear.

The removal of rc_type should indeed be documented, just like other removed columns (e.g. rc_moved_to_ns), and the new DESCRIBE and SHOW INDEX outputs should be added. However, this shouldn’t happen before the columns are actually removed (“actual removal” may mean either that the change is merged or that the DROP COLUMN queries are run in production).

Change #1178899 merged by Ladsgroup:

[operations/puppet@production] maintain-views: Stop providing rc_new and rc_type to replicas

https://gerrit.wikimedia.org/r/1178899

Change #1183283 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] recentchanges: Allow registration of known rc_source values

https://gerrit.wikimedia.org/r/1183283

Change #1184959 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] recentchanges: Use the new extension attribute for active user queries

https://gerrit.wikimedia.org/r/1184959

Change #1183283 merged by jenkins-bot:

[mediawiki/core@master] recentchanges: Allow registration of known rc_source values

https://gerrit.wikimedia.org/r/1183283

Change #1184959 merged by jenkins-bot:

[mediawiki/core@master] recentchanges: Use the new extension attribute for active user queries

https://gerrit.wikimedia.org/r/1184959

Change #1187802 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/ORES@master] Replace most usages of rc_type with rc_source

https://gerrit.wikimedia.org/r/1187802

Change #1187807 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/ORES@master] Allow filtering models by rc_source instead of rc_type

https://gerrit.wikimedia.org/r/1187807

Change #1180975 merged by jenkins-bot:

[mediawiki/core@master] Replace some usages of rc_type with rc_source

https://gerrit.wikimedia.org/r/1180975

Change #1180133 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Replace usages of rc_type with rc_source

https://gerrit.wikimedia.org/r/1180133

Change #1190323 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Translate@master] Replace usages of rc_type with rc_source

https://gerrit.wikimedia.org/r/1190323

Change #1190323 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Replace usages of rc_type with rc_source

https://gerrit.wikimedia.org/r/1190323

Change #1191744 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Echo@master] Replace usage of rc_type with rc_source

https://gerrit.wikimedia.org/r/1191744

Change #1191748 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/FlaggedRevs@master] Replace usage of rc_type with rc_source

https://gerrit.wikimedia.org/r/1191748

Change #1191753 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] ChangesListSpecialPage: Use rc_source instead of rc_type

https://gerrit.wikimedia.org/r/1191753

Change #1191754 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Deprecate SpecialWatchlistGetNonRevisionTypes Hook

https://gerrit.wikimedia.org/r/1191754

Change #1191803 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] RecentChangeLookup: Introduce method to check if rc has primary source

https://gerrit.wikimedia.org/r/1191803

Change #1191754 merged by jenkins-bot:

[mediawiki/core@master] Deprecate SpecialWatchlistGetNonRevisionTypes Hook

https://gerrit.wikimedia.org/r/1191754

Change #1191753 abandoned by Zabe:

[mediawiki/core@master] ChangesListSpecialPage: Use rc_source instead of rc_type

Reason:

Code to be dropped in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1191646

https://gerrit.wikimedia.org/r/1191753

Change #1187807 merged by jenkins-bot:

[mediawiki/extensions/ORES@master] Allow filtering models by rc_source instead of rc_type

https://gerrit.wikimedia.org/r/1187807

Change #1187802 merged by jenkins-bot:

[mediawiki/extensions/ORES@master] Replace most usages of rc_type with rc_source

https://gerrit.wikimedia.org/r/1187802

Change #1191744 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Email notifications: Replace rc_type with rc_source, ignore Flow edits

https://gerrit.wikimedia.org/r/1191744

Change #1191803 merged by jenkins-bot:

[mediawiki/core@master] RecentChangeLookup: Introduce method to check if rc has primary source

https://gerrit.wikimedia.org/r/1191803

Change #1191748 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Replace usages of rc_type with rc_source

https://gerrit.wikimedia.org/r/1191748

Change #1197028 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Use rc_source instead of rc_type in ORES config

https://gerrit.wikimedia.org/r/1197028

Change #1197028 merged by jenkins-bot:

[operations/mediawiki-config@master] Use rc_source instead of rc_type in ORES config

https://gerrit.wikimedia.org/r/1197028

Mentioned in SAL (#wikimedia-operations) [2025-10-21T23:47:14Z] <zabe@deploy2002> Started scap sync-world: Backport for [[gerrit:1197028|Use rc_source instead of rc_type in ORES config (T74157)]]

Mentioned in SAL (#wikimedia-operations) [2025-10-21T23:52:01Z] <zabe@deploy2002> zabe: Backport for [[gerrit:1197028|Use rc_source instead of rc_type in ORES config (T74157)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-10-21T23:56:31Z] <zabe@deploy2002> Finished scap sync-world: Backport for [[gerrit:1197028|Use rc_source instead of rc_type in ORES config (T74157)]] (duration: 09m 16s)

Change #1199087 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/ORES@master] Emit deprecation warnings when a model is configured with types

https://gerrit.wikimedia.org/r/1199087

Change #1199087 merged by jenkins-bot:

[mediawiki/extensions/ORES@master] Emit deprecation warnings when a model is configured with types

https://gerrit.wikimedia.org/r/1199087

Change #1200089 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Drop SpecialWatchlistGetNonRevisionTypesHook

https://gerrit.wikimedia.org/r/1200089

Change #1181177 abandoned by Adarsh2406:

[mediawiki/core@master] Use rc_source and drop rc_type

https://gerrit.wikimedia.org/r/1181177

Change #1200089 merged by jenkins-bot:

[mediawiki/core@master] Drop SpecialWatchlistGetNonRevisionTypesHook

https://gerrit.wikimedia.org/r/1200089

Change #1203250 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Remove remaining usages of rc_type

https://gerrit.wikimedia.org/r/1203250

Change #1203250 merged by jenkins-bot:

[mediawiki/core@master] Stop reading from the rc_type field

https://gerrit.wikimedia.org/r/1203250

Change #1205974 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/ORES@master] Drop support for filtering model for rc_type

https://gerrit.wikimedia.org/r/1205974

Change #1205977 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Flow@master] Stop writing to rc_type

https://gerrit.wikimedia.org/r/1205977

Change #1205978 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Wikistories@master] Stop writing to rc_type

https://gerrit.wikimedia.org/r/1205978

Change #1205979 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/WikiLambda@master] Stop writing to rc_type

https://gerrit.wikimedia.org/r/1205979

Change #1205980 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Wikibase@master] Stop writing to rc_type

https://gerrit.wikimedia.org/r/1205980

Change #1205981 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Stop writing to rc_type

https://gerrit.wikimedia.org/r/1205981

Change #1205982 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Deprecate RecentChange::parse(From|To)RCType

https://gerrit.wikimedia.org/r/1205982

Change #1205974 merged by jenkins-bot:

[mediawiki/extensions/ORES@master] Drop support for filtering model by rc_type

https://gerrit.wikimedia.org/r/1205974

Change #1205979 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Stop writing to rc_type

https://gerrit.wikimedia.org/r/1205979

Change #1205978 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Stop writing to rc_type

https://gerrit.wikimedia.org/r/1205978

Change #1205977 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Stop writing to rc_type

https://gerrit.wikimedia.org/r/1205977

Change #1205982 merged by jenkins-bot:

[mediawiki/core@master] Deprecate RecentChange::parse(From|To)RCType

https://gerrit.wikimedia.org/r/1205982

Change #1206436 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Drop rc_type from recentchanges

https://gerrit.wikimedia.org/r/1206436

Change #1205980 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop writing to rc_type

https://gerrit.wikimedia.org/r/1205980

Change #1205981 merged by jenkins-bot:

[mediawiki/core@master] Stop writing to rc_type

https://gerrit.wikimedia.org/r/1205981

Change #1206436 merged by jenkins-bot:

[mediawiki/core@master] Drop rc_type from recentchanges

https://gerrit.wikimedia.org/r/1206436

Zabe changed the status of subtask T410531: Drop rc_type from recentchanges in wmf production from Open to Stalled.
Zabe added a project: DBA.
Zabe moved this task from Triage to Done on the DBA board.