Page MenuHomePhabricator

VisualEditor: [Regression] Adding category sort keys no longer working
Closed, ResolvedPublic

Description

Steps to reproduce:

  1. Open a page and go to Page options > Categories.
  1. (Add a category if none exist.) Edit a category to add a sort key.
  1. Save page.
  1. Check diff: no sort key was added. :-(

Confirmed in Firefox 32 and Safari 6.2 on Macs and Windows, so it's probably happening everywhere.

This doesn't seem to be bug 48555.


Version: unspecified
Severity: normal

Details

Reference
bz72168

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:45 AM
bzimport set Reference to bz72168.

Change 167876 had a related patch set uploaded by Alex Monk:
CategoryPopupWidget: Track popup hiding again so sortkey changes are applied

https://gerrit.wikimedia.org/r/167876

Change 167877 had a related patch set uploaded by Alex Monk:
PopupWidget: Remove references to 'show' and 'hide' events

https://gerrit.wikimedia.org/r/167877

Change 167877 merged by jenkins-bot:
PopupWidget: Remove references to 'show' and 'hide' events

https://gerrit.wikimedia.org/r/167877

Change 167876 merged by jenkins-bot:
CategoryPopupWidget: Track popup hiding again so sortkey changes are applied

https://gerrit.wikimedia.org/r/167876

Verified in betalabs, test2, and wikimedia - e.g. a Category gets added as [[Category:Cat2|Sort_added]]

Verified the fix in production