Page MenuHomePhabricator

VisualEditor: It's not possible to "Apply changes" from the transclusion dialog after it has been emptied
Closed, ResolvedPublic

Description

It's not possible to "Apply changes" from the transclusion dialog after it has been emptied (all template and wikitext blocks in it have been removed), because the button is disabled.

Split off from bug 71701.


Version: unspecified
Severity: normal

Details

Reference
bz72191

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:46 AM
bzimport set Reference to bz72191.
matmarex created this task.Oct 17 2014, 5:21 PM

Yeah; this should be available when there are changes (and on clicking it should remove the transclusion), but it should still be disabled in "insert" mode (as there's nothing to insert).

gerritadmin wrote:

Change 168721 had a related patch set uploaded by Alex Monk:
Allow removing all parts from a transclusion to remove the transclusion

https://gerrit.wikimedia.org/r/168721

gerritadmin wrote:

Change 168721 merged by jenkins-bot:
Allow removing all parts from a transclusion to remove the transclusion

https://gerrit.wikimedia.org/r/168721

Verified in betalabs.

Works correctly in test2. The bug still exists in production.

To check if my steps are correct:

1.Insert a template 'Cite web'

  1. Open template properties for editing - and click 'Show options'.
  1. Click on a trash can symbol - all fields should be empty, but 'Apply changes' is active.
  1. clicking on 'Apply changes' should delete the template.

test2 is in production.

Hey Elena, it has not yet made it to production(en.wiki), since it got fixed in wmf6.Lets check it on production after wednesday deployment.

https://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap has some more details about what version (see 'Target Milestone') goes to which Wikimedia production wiki and when. Right now this change should be on the following sites in Wikimedia production: mediawikiwiki, testwiki, test2wiki, testwikidatawiki

Verified the fix in production.