Page MenuHomePhabricator
Create Task
Maniphest T74387

"createaccount" action failure should return the name of the extension that caused it to fail.
Closed, ResolvedPublic
Actions

Description

In our Android app, we allow the user to create an account, and if the API rejects the account creation request, we would like to tell the user exactly why it was rejected.

When the createaccount action fails because of an extension, we get back a "code" of "createaccount-hook-aborted", which is not specific enough for us to understand what the exact error is.

We do see the "info" text, which is HTML, but we don't want to display it as-is inside the app, for various reasons (e.g. localization).

Ideally the API should tell us which extension was responsible for rejecting the request, so that we may decide how to present the corresponding error to the user.

Version: unspecified
Severity: normal

Details

Reference
bz72387

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:58 AM
• bzimport added a project: MediaWiki-Action-API.
• bzimport set Reference to bz72387.
• bzimport added a subscriber: Unknown Object (MLST).
Dbrant created this task.Oct 22 2014, 9:21 PM
Legoktm added a comment.Oct 23 2014, 5:58 AM

I think AntiSpoof just needs to use the API specific hooks (like was done to ConfirmEdit in Id628defaeab2bf5979ca8f4284d14fc42d9c3e46).

Anomie added a comment.Oct 23 2014, 4:22 PM

The API-specific hooks aren't actually necessary for this. AddNewAccountApiForm is really intended for mapping from parameters named in API style (such as "captchaid" and "captchaword") to form style (such as "wpCaptchaId" and "wpCaptchaWord"), while AddNewAccountApiResult is for adjusting a non-fatal outcome.

AntiSpoof needs to update its AbortNewAccount hook function to use the $abortStatus parameter added to that hook in 1.23, if it wants to avoid a generic 'createaccount-hook-aborted' message.

Krenair mentioned this in T74331: When trying to create an account, Android mobile app doesn't show error messages from AntiSpoof extension, blocking registration with no explanation.Jan 3 2015, 4:07 PM
bd808 added projects: AntiSpoof, good first task.Feb 13 2015, 12:17 AM
bd808 subscribed.
Krenair added a subscriber: Nikerabbit.Feb 16 2015, 5:58 PM

Is this really good first task ? AntiSpoof uses a few different messages (antispoof-conflict-top, antispoof-conflict-item, antispoof-conflict-bottom) to generate some HTML so it can show multiple conflicts, but the Status class wants to be given a Message.

bd808 added a comment.Feb 16 2015, 6:05 PM
In T74387#1041917, @Krenair wrote:

Is this really good first task ? AntiSpoof uses a few different messages (antispoof-conflict-top, antispoof-conflict-item, antispoof-conflict-bottom) to generate some HTML so it can show multiple conflicts, but the Status class wants to be given a Message.

I threw on that tag based on:

In T74387#773225, @Anomie wrote:

AntiSpoof needs to update its AbortNewAccount hook function to use the $abortStatus parameter added to that hook in 1.23, if it wants to avoid a generic 'createaccount-hook-aborted' message.

Which sounded good first task to me but may really not be.

Anomie moved this task from Unsorted to Non-core-API stuff on the MediaWiki-Action-API board.Feb 19 2015, 6:25 PM
• Deskana merged a task: T74331: When trying to create an account, Android mobile app doesn't show error messages from AntiSpoof extension, blocking registration with no explanation.Feb 23 2015, 6:36 AM
• Deskana added subscribers: matmarex, • bearND, Ragesoss, • KLans_WMF.
• bearND awarded a token.Apr 28 2015, 8:49 PM
Dbrant added a parent task: T107082: Creating a user with username=Rrrr produces a warning that displays html entities/code.Aug 11 2015, 6:14 PM
EddieGP removed a project: good first task.Mar 21 2017, 4:42 PM
Aklapper removed subscribers: Anomie, • wikibugs-l-list.Oct 16 2020, 5:02 PM
matmarex closed this task as Resolved.Jun 26 2024, 1:43 PM

I think this is probably resolved. The generic "createaccount-hook-aborted" message mentioned in the task description is not used since 2018 (see https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1049937), so any extension has to provide a custom error message. And speaking of AntiSpoof specifically, it tried really hard to provide a useless error message despite the requirement, until I fixed T167163 last year.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits