Page MenuHomePhabricator

VisualEditor: MWTitleInputWidget should return titles
Closed, ResolvedPublic

Description

MWTitleInputWidget should have a .getTitle() getter (which can return null, if the value isn't a valid title). Using this getter should be preferred over .getValue(). Callers of MWTitleInputWidget.getValue() should be converted to .getTitle(), and they should check for null-ness, because we probably have more bugs like bug 71998 hiding in various places.


Version: unspecified
Severity: normal

Details

Reference
bz72468

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:47 AM
bzimport set Reference to bz72468.
Catrope created this task.Oct 24 2014, 1:41 AM

Also, per bug 71249, now that we have isValid() in TextInputWidget, it makes sense for MWTitleInputWidget to reimplement isValid() as a check for getTitle() not being null.

Change 169603 had a related patch set uploaded by SuchetaG:
Introducing getTitle() in MWTitleInputWidget

https://gerrit.wikimedia.org/r/169603

Change 169603 merged by jenkins-bot:
Introducing getTitle() in MWTitleInputWidget

https://gerrit.wikimedia.org/r/169603