Page MenuHomePhabricator
Create Task
Maniphest T74506

QUnit failures in browser for toggling tests
Closed, ResolvedPublic
Actions

Description

http://127.0.0.1:8080/wiki/Special:JavaScriptTest/qunit?module=MobileFrontend%20toggle.js%3A%20remember%20expanded%20sections

causes various issues.
We should really be using sinon in some way here.

Side note:

  • getExpandedSections has side effects (updates local storage)
  • Really this code should be refactored. The toggle code is now horribly unreadable. We should think about giving it a complete rewrite, maybe making use of Page.

Version: unspecified
Severity: normal

Details

Reference
bz72506

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:49 AM
• bzimport added a project: Don't use – MobileFrontend-Hygiene.
• bzimport set Reference to bz72506.
Jdlrobson created this task.Oct 25 2014, 12:20 AM
• bzimport added a comment.Oct 25 2014, 12:25 AM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/bXRsm7AE

• bzimport added a comment.Oct 27 2014, 6:18 PM

gerritadmin wrote:

Change 169020 had a related patch set uploaded by Jdlrobson:
Fix failing tests

https://gerrit.wikimedia.org/r/169020

• bzimport added a comment.Oct 27 2014, 6:21 PM

gerritadmin wrote:

Change 169020 merged by Kaldari:
Fix failing tests

https://gerrit.wikimedia.org/r/169020

Jdforrester-WMF edited projects, added Technical-Debt, MobileFrontend-General-or-Unknown; removed Don't use – MobileFrontend-Hygiene.Dec 8 2014, 9:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL