Page MenuHomePhabricator

Edit preview doesn't work for article pages (no JS error)
Closed, ResolvedPublic

Description

If you try to preview an edit in the Wikitext editor, no preview is displayed (on en.wiki). Unlike Bug 72521, no Javascript error is thrown. It may or may not be related.


Version: unspecified
Severity: critical
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=72521

Details

Reference
bz72522

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:50 AM
bzimport set Reference to bz72522.
kaldari created this task.Oct 26 2014, 2:14 AM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ZybYHgNQ

Looks like Section template got broken.

To fix it:
mw.mobileFrontend.require( 'Section' ).prototype.template = mw.mantle.template.compile( '{{#heading}}<h2><span id="{{anchor}}">{{{heading}}}</span><a href="#editor/{{id}}" data-section="{{id}}" class="edit-page">{{editLabel}}</a></h2>{{/heading}}<div>{{{content}}}</div>', 'hogan' )

  • Bug 72528 has been marked as a duplicate of this bug. ***

gerritadmin wrote:

Change 168822 had a related patch set uploaded by Florianschmidtwelzow:
Fix missing edit preview

https://gerrit.wikimedia.org/r/168822

gerritadmin wrote:

Change 168822 merged by Kaldari:
Fix missing edit preview

https://gerrit.wikimedia.org/r/168822

gerritadmin wrote:

Change 169039 had a related patch set uploaded by Florianschmidtwelzow:
Fix missing edit preview

https://gerrit.wikimedia.org/r/169039

gerritadmin wrote:

Change 169040 had a related patch set uploaded by Florianschmidtwelzow:
Fix missing edit preview

https://gerrit.wikimedia.org/r/169040

gerritadmin wrote:

Change 169039 merged by jenkins-bot:
Fix missing edit preview

https://gerrit.wikimedia.org/r/169039

gerritadmin wrote:

Change 169040 merged by jenkins-bot:
Fix missing edit preview

https://gerrit.wikimedia.org/r/169040