Page MenuHomePhabricator

Inconsistent directionality in the Android App's nearby screen
Closed, DuplicatePublic

Description

a screenshot with the problem

My phone's locale is Hebrew. I set the Wikipedia language to English.

I tried the nearby screen and it produced relevant results, but their display was weird: some were aligned to the left and some were aligned to the right. See the screenshot.

Given that the content is from the English Wikipedia, it makes sense to make all the titles aligned to the left. Speaking more generally, all titles should have the direction of the page's content language.

(It would be even better if the title could have a language that is different from the page's content language, but that's an entirely separate bug.)


Version: Beta
Severity: normal

Attached:

Screenshot_2014-10-26-09-53-33.png (1×1 px, 401 KB)

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:52 AM
bzimport set Reference to bz72554.
bzimport added a subscriber: Unknown Object (MLST).

(Looking at the screenshot, it may be that the names that are longer than one line get aligned to the left, but it may be just a coincidence. In any case, this shouldn't be the thing that sets the alignment.)

Change 207653 had a related patch set uploaded (by Dbrant):
Fix text directionality consistency in Nearby.

https://gerrit.wikimedia.org/r/207653

bearND set Security to None.

Change 207653 merged by jenkins-bot:
Fix text directionality consistency in Nearby.

https://gerrit.wikimedia.org/r/207653

Given that the content is from the English Wikipedia, it makes sense to make all the titles aligned to the left.

Should it be true for the inverse - locale=Eng, wikipedia lang=Hebrew?

Phone locale is Eng and Wikipedia lang is Hebrew: articles' titles are displayed left-aligned:

Screenshot_2015-05-04-17-13-21.png (1×1 px, 132 KB)

  1. Also, there is a question with History and Saved pages - when some of Saved or visited articles are in RTL language, their titles alignment is displayed based on the phone locale not on the articles' content language.

The latest build 2.0.101-alpha-2015-05-05 - when the wiki lang is switched to Hebrew:

Screenshot_2015-05-05-15-08-52.jpg (1×800 px, 180 KB)

The specific bug of misaligned titles(too much white space) seems to be fixed.

More discussion is needed and follow-up task(s) will be filed.

If we need signoff on the alignment of the titles along one single scan line, then the title for this task must be edited.
@kristenlans @Dbrant - could you please do that and file a separate ticket for follow-up tasks?

I'm merging this task into the broader task where we'll improve overall consistency of all our list items, which will include RTL considerations.