Page MenuHomePhabricator

ChangeOpClaim using obsolete Entity::setClaims causes stack trace when adding statement on Property page
Closed, ResolvedPublic

Description

Causes stack trace when trying to set a statement via the UI on a Property page.

Fatal error: Call to undefined method Wikibase\DataModel\Entity\Property::setClaims() in C:\Program Files (x86)\Apache Software Foundation\Apache2.2\htdocs\mediawiki\core\extensions\Wikibase\repo\includes\ChangeOp\ChangeOpClaim.php on line 113

Call Stack:

0.0010     366208   1. {main}() C:\Program Files (x86)\Apache Software Foundation\Apache2.2\htdocs\mediawiki\core\api.php:0
0.2320   16288936   2. ApiMain->execute() C:\Program Files (x86)\Apache Software Foundation\Apache2.2\htdocs\mediawiki\core\api.php:85
0.2320   16288968   3. ApiMain->executeActionWithErrorHandling() C:\Program Files (x86)\Apache Software Foundation\Apache2.2\htdocs\mediawiki\core\includes\api\ApiMain.php:358
0.2320   16330416   4. ApiMain->executeAction() C:\Program Files (x86)\Apache Software Foundation\Apache2.2\htdocs\mediawiki\core\includes\api\ApiMain.php:387
0.3580   23078008   5. Wikibase\Api\SetClaim->execute() C:\Program Files (x86)\Apache Software Foundation\Apache2.2\htdocs\mediawiki\core\includes\api\ApiMain.php:948
0.3810   24554656   6. Wikibase\Api\ClaimModificationHelper->applyChangeOp() C:\Program Files (x86)\Apache Software Foundation\Apache2.2\htdocs\mediawiki\core\extensions\Wikibase\repo\includes\api\SetClaim.php:80
0.6170   25377328   7. Wikibase\ChangeOp\ChangeOpClaim->apply() C:\Program Files (x86)\Apache Software Foundation\Apache2.2\htdocs\mediawiki\core\extensions\Wikibase\repo\includes\api\ClaimModificationHelper.php:205

Version: master
Severity: major
Whiteboard: u=dev c=backend p=0

Details

Reference
bz72671

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 4:00 AM
bzimport set Reference to bz72671.
bzimport added a subscriber: Unknown Object (MLST).

gerritadmin wrote:

Change 170342 had a related patch set uploaded by Aude:
Fix fatal error in ChangeOpClaim for properties

https://gerrit.wikimedia.org/r/170342

gerritadmin wrote:

Change 170576 had a related patch set uploaded by Aude:
Fix for statements on properties in ChangeOpClaim

https://gerrit.wikimedia.org/r/170576

made a patch for ChangeOpClaim, though i suspect issues also exist in ChangeOpClaimRemove and perhaps elsewhere.

gerritadmin wrote:

Change 170576 merged by jenkins-bot:
Fix for statements on properties in ChangeOpClaim

https://gerrit.wikimedia.org/r/170576

this particular issue is fixed, although it's probably not possible to remove statements on properties, etc.

see bug 72879 for issues in the other change ops classes.