Page MenuHomePhabricator

VisualEditor: [Regression wmf6] There is an extra space appearing at the top of the toolbar inside VE
Closed, ResolvedPublic

Description

Screenshot

There is an extra space appearing at the top of the toolbar inside VE

See the screenshot attached


Version: unspecified
Severity: minor

Attached:

Details

Reference
bz72693

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:45 AM
bzimport set Reference to bz72693.
Ryasmeen created this task.Oct 29 2014, 6:43 PM

This is because of the mw-indicators div. It's empty if there are no indicators, but the fact that it floats right and the VE toolbar then has clear: both; seems to make it take up space somehow.

Even if an empty indicators div doesn't take up space: if there are indicators, where do we put them in VE mode?

Butbutbut wasn't that supposed to be fixed with c81ed82f?

(In reply to Bartosz Dziewoński from comment #2)

Butbutbut wasn't that supposed to be fixed with c81ed82f?

Apparently it didn't work.

gerritadmin wrote:

Change 169860 had a related patch set uploaded by Bartosz Dziewoński:
Hide page status indicators even if they aren't :visible

https://gerrit.wikimedia.org/r/169860

gerritadmin wrote:

Change 169861 had a related patch set uploaded by Jforrester:
Hide page status indicators even if they aren't :visible

https://gerrit.wikimedia.org/r/169861

gerritadmin wrote:

Change 169860 merged by jenkins-bot:
Hide page status indicators even if they aren't :visible

https://gerrit.wikimedia.org/r/169860

gerritadmin wrote:

Change 169861 merged by jenkins-bot:
Hide page status indicators even if they aren't :visible

https://gerrit.wikimedia.org/r/169861

Verified the fix in Betalabs and test2

Verified the fix in production