Page MenuHomePhabricator

OOUI PHP: Use a namespace for our classes
Closed, ResolvedPublic

Description


Version: unspecified
Severity: enhancement

Details

Reference
bz72705

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:46 AM
bzimport set Reference to bz72705.

gerritadmin wrote:

Change 170501 had a related patch set uploaded by Bartosz Dziewoński:
OOUI PHP: Use 'OOUI' namespace instead of 'OoUi' class name prefix

https://gerrit.wikimedia.org/r/170501

gerritadmin wrote:

Change 170501 merged by jenkins-bot:
OOUI PHP: Use 'OOUI' namespace instead of 'OoUi' class name prefix

https://gerrit.wikimedia.org/r/170501

There were some concerns raised on the patch that this usage doesn't quite match PHP best practices, but we'd need to do quite a bit of renaming to do that (also on the JS side to stay consistent).

I'm open to suggestions that don't require me to do massive semi-manual search-and-replaces on thousands of lines of code that uses JS OOUI already. :)